Type hint wrapping after comment

[henryiii]

Describe the style change

For some reason, black weirdly wraps a type hint only if it is after a comment.

Examples in the current Black style

def get_requires_for_build_sdist(
    config_settings: dict[str, str | list[str]] | None = None
) -> list[str]:
    return ["pathspec", "pyproject_metadata"]

def get_requires_for_build_sdist(
    # pylint: disable-next=unused-argument
    config_settings: dict[str, str | list[str]]
    | None = None
) -> list[str]:
    return ["pathspec", "pyproject_metadata"]

Desired style

def get_requires_for_build_sdist(
    config_settings: dict[str, str | list[str]] | None = None
) -> list[str]:
    return ["pathspec", "pyproject_metadata"]

def get_requires_for_build_sdist(
    # pylint: disable-next=unused-argument
    config_settings: dict[str, str | list[str]] | None = None
) -> list[str]:
    return ["pathspec", "pyproject_metadata"]

Additional context

Tested with both regular black and --preview, and with target version.

[felix-hilden]

All for it, wouldn't consider this change controversial in any way as the line length is not exceeded!

[charlie572]

The function definition is split using left_hand_split, and this yields a line that looks like "# pylint: disable-next=unused-argumentconfig_settings: dict[str, str | list[str]] | None = None". Then, this line gets split using delimiter_split, standalone_comment_split, and right_hand_split, in that order.

Changing the order to put standalone_comment_split first fixes the issue, but causes some tests to fail because some comma-separated items get put on one line where they shouldn't.

[charlie572]

Am I correct in thinking that it should have split the line using standalone_comment_split instead of delimiter_split? I'm not familiar with how black works.