Framework's test suite compatibility prior to R2014a #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `runxunit` command does not run recursively go through test folders to find all tests. Therefore trying to run the tests for the xUnit framework itself was more cumbersome then strictly necessary. Closes psexton#22.
As `localfunctions` is only available _after_ R2013b, the framework's own tests do not run on older MATLAB versions, even though they are supported. By using the more elaborate syntax for creating an array of function handles to subfunctions inside a test suite the test suite becomes compatible with all supported MATLAB versions. Fixes psexton#21.
|
Tests passed on win64 on every "b" version 2011-2016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @nzbuu in #21,
matlab-xunits own test suite does not run on versions prior to R2014a, aslocalfunctionsdoes not exist in those versions. Even though in my previous update I explicitly mentioned in the documentation that special care needs to be taken when writing test suite spanning this wide range of MATLAB versions, I forgot to apply this lesson to the framework's own test suite.I have run the tests in R2014a and R2016b and everything passes. Unfortunately, I currently cannot install older versions than R2014a as I'm on Ubuntu and my network interfaces do not follow the
eth*oren*naming convention required by releases prior to that version (as describe here). Perhaps either @psexton or @nzbuu can verify the tests now run as expected? Given this is the same technique used to get function handles to packaged subfunction test suites in versions wherelocalfunctionsis broken, I'm fairly confident they do, but it probably doesn't hurt to check.While I was at it, I've also removed the
srcsubdirectory fromtestsfixing #22.