Add OptionExtensions to FileDescriptor #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @pseudomuto
After starting to incorporate the changes from #2 into
protoc-gen-doc, I discovered that theFileDescriptorstruct doesn't have the embeddedcommon, so theOptionExtensionswere missing from it.What is Changing?
This Pull Request adds
OptionExtensionsto theFileDescriptorstruct and adds the appropriate code to set the field.How is it Changing?
Basically copy-paste, except that I moved the common logic into a separate func.
What Could Go Wrong?
This change is tested in the same way as I tested #2, so should be fine.