Introduce Ruff #234
Merged
Introduce Ruff #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits. |
pschmitt
reviewed
Feb 21, 2024
|
Yea, I'm currently installing my gpg key again. Will sign them after lunch. |
pschmitt
reviewed
Feb 21, 2024
Comment on lines
-15
to
+17
| exclude = ["tests/*"] | ||
| packages = [ | ||
| { include = "roombapy" }, | ||
| ] |
There was a problem hiding this comment.
Does this effectively exclude tests still?
There was a problem hiding this comment.
I think so, I checked my own libraries and they never exclude tests but they have this, so I'm assuming this does it implicitly
pschmitt
reviewed
Feb 21, 2024
pschmitt
reviewed
Feb 21, 2024
pschmitt
reviewed
Feb 21, 2024
Orhideous
approved these changes
Feb 21, 2024
Introduce Ruff
|
Commits are now signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing ruff, a rust based linter and formatter that neatly fits in with the current libs.
Currently I ignored a lot of rules. In follow up PRs I will chip away on these rules, making clearer what rules does what :)