Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vietnamese language #121

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

dungphanxuan
Copy link

@dungphanxuan dungphanxuan commented Feb 24, 2022

Done 90%

@dungphanxuan
Copy link
Author

@pschlan I have updated the Vietnamese language and added Japanese and Korean languages, please see the changes and help me merge the code

@ShimadaNanaki
Copy link

@dungphanxuan @pschlan
I'm creating my repository in Japanese one right now, should I stop editing once I'm done? I'm Japanese and I'm trying my best not to use a translator, so I think it'll take a long time...

@dungphanxuan
Copy link
Author

@B4kedBr3ad Hi, I found that using Google translate, the content is correct over 90%. Not much semantic error, You can refer to it first and then edit the content for the meaning, so it saves a lot of time.

@ShimadaNanaki
Copy link

@B4kedBr3ad Hi, I found that using Google translate, the content is correct over 90%. Not much semantic error, You can refer to it first and then edit the content for the meaning, so it saves a lot of time.

Not90%, it's 50%

@pschlan
Copy link
Owner

pschlan commented Dec 17, 2022

Thanks for this, will review/merge ASAP!

api/languages/vi.php Outdated Show resolved Hide resolved
@dungphanxuan
Copy link
Author

Hi @B4kedBr3ad
I have this api/languages/ja.php (Copy from file api/languages/ja.php) file I want to translate into Japanese language. Can you help, thank you

@ShimadaNanaki
Copy link

There are quite a few things that need to be corrected in Japanese, so we think it would be better to push once and then correct them. What do you think?
@dungphanxuan @pschlan

@pschlan
Copy link
Owner

pschlan commented Dec 28, 2022

There are quite a few things that need to be corrected in Japanese, so we think it would be better to push once and then correct them. What do you think? @dungphanxuan @pschlan

I would prefer to merge this to the main branch only when it is in good shape. Until then, we can keep it in a branch / PR.
Another idea would be to have separate PRs for the different languages - might make it easier to merge the finished ones early.

@ShimadaNanaki
Copy link

Okay, let's split it up by language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants