Add user_filter to config to allow having lazy checks#15
Open
ardeshireshghi wants to merge 1 commit intopschinis:masterfrom
Open
Add user_filter to config to allow having lazy checks#15ardeshireshghi wants to merge 1 commit intopschinis:masterfrom
user_filter to config to allow having lazy checks#15ardeshireshghi wants to merge 1 commit intopschinis:masterfrom
Conversation
`config.user_filter` is a lambda that receives env runtime and can decide to add `sameSite` or not Bump to "0.2.0"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.user_filteris a lambda that receives env runtime and candecide to add
sameSiteor notBump to "0.2.0"
The rationale for adding this change is, the fact that we want to take into account other
Rackenvironment variables such as other headers to decide whether we want to add thesameSite. For example, we might want to do this conditional to an existing header (IS-MOBILE-APPLICATION)