Skip to content

Comments

Configurable behaviour for cookie defaults and overrides#14

Open
elengine wants to merge 5 commits intopschinis:masterfrom
elengine:cookie_defaults_and_overrides
Open

Configurable behaviour for cookie defaults and overrides#14
elengine wants to merge 5 commits intopschinis:masterfrom
elengine:cookie_defaults_and_overrides

Conversation

@elengine
Copy link

I offer one solution on the issue #2.

@elengine elengine requested a review from pschinis February 15, 2020 17:06
@georf
Copy link

georf commented Jun 2, 2020

Please merge this and create a new gem version!

@pschinis
Copy link
Owner

pschinis commented Jun 2, 2020

I haven't merged this because I think it goes beyond the scope of this gem. The gem is really just intended to patch over the behavior of older rails apps so they can continue working as they were before in newer versions of Chrome. Given the direction browsers are going it's not really meant to be a permanent solution and most of these apps will need to find ways to move away from the use of third party cookies in the near future. It already doesn't work in Safari unless the user changes their settings and there's talk of Chrome eventually disallowing these kinds of cookies in a similar way as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants