Problems when using IIS server (Windows Server)

[vladkorotnev]

I have an IIS FTP server which seems to be working fine according to manual input over Telnet.

230 User logged in.
SIZE /Music/10_Digitalized_Lossless
550 Access is denied. 
SIZE /Music/190204_04.WAV
213 58757732
QUIT
221 Goodbye.
Connection closed by foreign host.

However, when using TinyFTPClient, all files are returned as directories.

For testing, I've tried to modify the objectType method like this to log the parameter and response:

  ObjectType objectType(const char *file) {
    FTPLogger::writeLog(LOG_DEBUG, "FTPBasicAPI", "objectType");
    const char *ok_result[] = {"213", "550", nullptr};
    ObjectType result = TypeDirectory;
      ESP_LOGW("size request", "FILE[%s]", file);
    if (cmd("SIZE", file, ok_result)) {
      ESP_LOGW("size res", "FILE[%s] RESPONSE[%s]", file, result_reply);
      if (strncmp(result_reply, "213", 3) == 0) {
        result = TypeFile;
      }
    }
    return result;
  }

This produces the following log:

FILE[/Music/moh
] RESPONSE[550 The filename, directory name, or volume label syntax is incorrect. 

Looks like the library is not trimming off the \r\n properly on Windows Server machines, leaving the \r behind.

I'll try to make a PR if I get around to it but for now logging this here.

[pschatzmann]

Cool, a PR would be helpful since I don't have any Windows...

[vladkorotnev]

I have barely used Arduino's String class so please tell me if you know, would adding this in FTPFileIterator's cause any performance/memory issues?

buffer = stream_ptr->readStringUntil('\n');
if (buffer.endsWith("\r")) buffer.remove(buffer.length() - 1); //<- remove Windows line endings

[pschatzmann]

OK with me. I don't think this will cause any problems

[vladkorotnev]

There is actually a different read line function here:

TinyFTPClient/src/FTPBasicAPI.h

Line 225 in f27bf11

CStringFunctions::readln(*stream_ptr, result_str, FTP_RESULT_BUFFER_SIZE);

Does that support CRLF endings, maybe should use that instead?

[pschatzmann]

No, but you can easily correct this method. Check if the last character is a lf and if so set it to 0