Many different optimizations to improve performance and capabilities.#7
Many different optimizations to improve performance and capabilities.#7drakmor wants to merge 64 commits intops5-payload-dev:masterfrom
Conversation
- add buffered control reader, socket tuning, per-connection transfer buffer, and detached thread setup - implement ASCII transfer mode with CRLF conversion; disable REST/SIZE in ASCII and reset REST on RETR/TYPE - add upload resume validation and safer STOR seek/EOF checks - expand listing support: larger LIST buffer, NLST/MLSD/MLST, proper facts/mtime, and fixed MLSD/MLST formatting - implement PASS/FEAT/OPTS/MDTM/STAT/HELP/MODE/STRU/ALLO/ABOR commands - add SELF verification toggle and optional verify in ELF extraction - harden I/O helpers (looped read/write/pread/pwrite, buffered copy) and make buffer sizes configurable - enable O2/Zen2 PS5 build flags and fix MLST/LIST/data read edge cases
…t slows down download speed by 20-50%.
…self files are checked.
…to ps5-payload-dev-master
|
I will comment here on this PR, and suggest you start from a fresh clone of current upstream master and make feature branches that you send individual PRs for. |
|
On second though, could you provide a bullet list of the new capabilities first, and why it is needed. A lot of the ftp protocol is scattered acroos several RFCs, and many features are not really needed. Also, if a new command is not actually implemented, I would prefer to not have it at all, e.g., the authentication commands. All clients I have tested work without those commands. |
…see a proper data-channel failure.
…see a proper data-channel failure.
- add data-channel precheck and unified open/transfer errors - reuse helpers for PASV/EPSV and PORT/EPRT - rework LIST/NLST/MLSD path handling and transfer buffer - support LIST on files and consistent readdir/stat flow - extend MLST/MLSD facts (OS.unix types, unique, unix.mode/uid/gid) with symlink escaping - reject directory deletes in DELE
|
FYI: I've started integrating some of your improvements. Some questions:
Its gonna take a while for me to integrate all of this. I will get to cmd.c eventually |
|
Hello.
I am currently collecting the issues that arise, and towards the end of the week I will fix what I find and add edits for working with SELF, for example, so that the process is not killed when trying to read certain files. Added the latest commits to PR |
Sorry about the PR, but it's getting really hard to break it down into feature blocks.
I suggest we discuss it in the comments and remove the unnecessary bits.