Skip to content

Verify pod setup completion to fix LookKit issue #1369#641

Merged
ps2 merged 2 commits intops2:devfrom
itsmojo:verify-setup-completed
Nov 14, 2020
Merged

Verify pod setup completion to fix LookKit issue #1369#641
ps2 merged 2 commits intops2:devfrom
itsmojo:verify-setup-completed

Conversation

@itsmojo
Copy link
Contributor

@itsmojo itsmojo commented Oct 26, 2020

Don't have OmnipodPumpManager check cannula insertion as errors are lost
Have InsertCannulaSetupViewController do completion checking & report errors
Add optional finish case & Finish button to InsertCannulaSetupViewController
Add additional guard to prevent potential bad setup state problem
Remove unused cancelErrorCount var in InsertCannulaSetupViewController

Don't have OmnipodPumpManager check cannula insertion as errors are lost
Have InsertCannulaSetupViewController do completion checking & report errors
Add optional finish case & Finish button to InsertCannulaSetupViewController
Add additional guard to prevent potential bad setup state problem
Remove unused cancelErrorCount var in InsertCannulaSetupViewController
Copy link
Owner

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but it reads correct to me; just some comments on naming and a nit.

@ps2
Copy link
Owner

ps2 commented Oct 29, 2020

I'm wondering if the "finish" state would be better communicated to the user with some messaging like "Could not confirm successful insertion with the pod. Tap "Confirm Insertion" to check again". And change the button to "Confirm Insertion".

@itsmojo
Copy link
Contributor Author

itsmojo commented Oct 29, 2020

I'd rather not display anything saying "Could not confirm successful insertion with the pod" on errors as as the only cannula insertion confirmation that can be done is for the user to manually look for the pink color in the viewing window on top the pod. Also, by using the normal Loop error message for whatever error might have occurred, the user gets more information about what actually went wrong and how to correct it (e.g., "No response from pod. Please try repositioning the pod or the RileyLink and try again."). Additionally, using this approach there will be no additional new string to have to translate... ;-)

@itsmojo
Copy link
Contributor Author

itsmojo commented Oct 29, 2020

Decided to go with the more explicit needsCheckInsertion for the new State enum name and "Recheck Cannula Insertion" for the button label. Using "Recheck" in the button label description instead of "Check" helps give context for what the displayed error was about and is more correct & using "Cannula Insertion" instead of just "Insertion" matches the View title better.

@ps2 ps2 merged commit b681987 into ps2:dev Nov 14, 2020
@ps2
Copy link
Owner

ps2 commented Nov 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants