Verify pod setup completion to fix LookKit issue #1369#641
Conversation
Don't have OmnipodPumpManager check cannula insertion as errors are lost Have InsertCannulaSetupViewController do completion checking & report errors Add optional finish case & Finish button to InsertCannulaSetupViewController Add additional guard to prevent potential bad setup state problem Remove unused cancelErrorCount var in InsertCannulaSetupViewController
ps2
left a comment
There was a problem hiding this comment.
I didn't test this, but it reads correct to me; just some comments on naming and a nit.
OmniKitUI/ViewControllers/InsertCannulaSetupViewController.swift
Outdated
Show resolved
Hide resolved
OmniKitUI/ViewControllers/InsertCannulaSetupViewController.swift
Outdated
Show resolved
Hide resolved
|
I'm wondering if the "finish" state would be better communicated to the user with some messaging like "Could not confirm successful insertion with the pod. Tap "Confirm Insertion" to check again". And change the button to "Confirm Insertion". |
|
I'd rather not display anything saying "Could not confirm successful insertion with the pod" on errors as as the only cannula insertion confirmation that can be done is for the user to manually look for the pink color in the viewing window on top the pod. Also, by using the normal Loop error message for whatever error might have occurred, the user gets more information about what actually went wrong and how to correct it (e.g., "No response from pod. Please try repositioning the pod or the RileyLink and try again."). Additionally, using this approach there will be no additional new string to have to translate... ;-) |
|
Decided to go with the more explicit |
|
Thanks! |
Don't have OmnipodPumpManager check cannula insertion as errors are lost
Have InsertCannulaSetupViewController do completion checking & report errors
Add optional finish case & Finish button to InsertCannulaSetupViewController
Add additional guard to prevent potential bad setup state problem
Remove unused cancelErrorCount var in InsertCannulaSetupViewController