Remove CA region from selection #570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting pump regions, NA and CA both return North America on UI. Causes confusion while selecting. Changed NA to NA/CA in picker.
Owner
|
I believe this is to help users who have a pump that the region code on the back of the pump is "CA". For both pump region codes "CA" and "NA", we use the "North America" tuning. |
Contributor
Author
|
That's correct. |
Owner
|
I think the CA/NA distinction should be kept to let users of both pump types know what to input, even if it does end up with the same tuning. |
Contributor
Author
|
Created a new PR #573 with separate CA and NA regions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting pump regions, NA and CA both return North America on UI.
Causes confusion while selecting.
Changed NA to NA/CA in picker.