Use random seconds component on remote carb entries. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOOP-4116 DIY Sync
LOOP-4190 DIY Sync
LOOP-4371 DIY Sync
…ates LOOP-887 Keycloak updates
Tidepool Sync
Updated translations from Lokalise on Sat Aug 19 14:25:48 CDT 2023
Tidepool Sync
* Upload cgm events * Add sensor id to Sensor Start treatment * Record more info about glucose sample source
Tidepool Sync
Upload pump events
Updated translations from Lokalise on Sun Oct 22 11:55:50 CDT 2023
ps2
pushed a commit
to LoopKit/NightscoutService
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can add a remote carb entry from Nightscout. The input box allows a start date/time to be selected. The "start-time" seconds component is always "00". If a user inputs 2 entries for the same time, this can be a problem. Nightscout expects treatments to have unique "created-date"s (which I believe is derived from "start-time" in the carb entry case). The result is the 2nd remote carb entry will not be visible in Nightscout or Caregiver. The fix here on the Loop side is to add a random seconds component to each incoming remote carb entry.
There is more information in the attached Caregiver case, including some information from Ben West LoopKit/LoopCaregiver#33