Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous Runtime Fixes & Improvements - Terence #1673

Closed
wants to merge 54 commits into from

Conversation

terencechain
Copy link
Member

In conjunction with #1667 to address better run time experience as well as fixing bugs 🐻

Key changes:

  • Log slot N - genesis slot
  • Log each block processing step when it has successfully completed

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #1673 into master will decrease coverage by 1.34%.
The diff coverage is 57.83%.

@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
- Coverage   72.22%   70.88%   -1.35%     
==========================================
  Files          97       97              
  Lines        7328     6886     -442     
==========================================
- Hits         5293     4881     -412     
+ Misses       1573     1560      -13     
+ Partials      462      445      -17

Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove validator/.main.go.swp and add *.swp to .gitignore please

@codecov-io
Copy link

Codecov Report

Merging #1673 into master will increase coverage by <.01%.
The diff coverage is 57.83%.

@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
+ Coverage   70.88%   70.88%   +<.01%     
==========================================
  Files          97       97              
  Lines        6879     6886       +7     
==========================================
+ Hits         4876     4881       +5     
  Misses       1560     1560              
- Partials      443      445       +2

@terencechain
Copy link
Member Author

closed via #1674

@nisdas nisdas deleted the better-logging-1 branch April 20, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants