Pending Attestations RPC Server/Client Implementation #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Ready For Review
rauljordan
requested review from
prestonvanloon,
nisdas and
terencechain
and removed request for
prestonvanloon and
nisdas
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
=======================================
Coverage 71.35% 71.35%
=======================================
Files 94 94
Lines 6657 6657
=======================================
Hits 4750 4750
Misses 1500 1500
Partials 407 407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1565 and a follow-up to #1606
Description
Write why you are making the changes in this pull request
In #1606, a method of obtaining pending attestations up to MAX_ATTESTATIONS from the operations service was implemented. This allows us to implement an RPC method in our server/client which can allow proposers to retrieve these pending attestations when performing their proposal responsibility.
Write a summary of the changes you are making
This PR implements a simple RPC server method called
PendingAttestations, which returns a list of*pb.Attestationfor a proposer to include in a beacon block. It also implements the call in theProposerBlockmethod invalidator/client/validator_propose.go. This PR adds relevant tests to ensure the behavior works as expected.Link anything that would be helpful or relevant to the reviewers
Diff is large due to gomock.