ToBlinded: Use Fulu.
#14797
Merged
ToBlinded: Use Fulu.
#14797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
reviewed
Jan 15, 2025
| } | ||
| header, err := PayloadToHeaderFulu(payload) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "payload to header fulu") |
There was a problem hiding this comment.
In all other cases we've always just returned the error, if this is clearer should we add an errors.Wrap for the other fork versions too?
There was a problem hiding this comment.
We, unless exception, should not return errors without wrapping them, because its make debugging much harder.
I'll add wrappers for other errors too.
james-prysm
approved these changes
Jan 15, 2025
saolyn
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
ToBlinded: Use Fulu for Fulu fork instead of Electra.Acknowledgements