Implement consensus spec v1.5.0-alpha.10 #14733

terencechain · 2024-12-17T22:36:18Z

This PR implements the following changes to the consensus spec. To ensure clarity and smooth review, I will add comments referencing the specific consensus spec changes, making it easy to follow:

terencechain · 2024-12-17T22:40:53Z

beacon-chain/core/altair/sync_committee.go

-		if effectiveBal*maxRandomByte >= maxEB*uint64(randomByte) {
-			cIndices = append(cIndices, cIndex)
+
+		if s.Version() >= version.Electra {


This change is related to: ethereum/consensus-specs#4039
We defer fieldparams for MaxRandomByte as single source of truth

terencechain · 2024-12-17T22:42:17Z

beacon-chain/core/blocks/payload.go

@@ -233,8 +233,14 @@ func verifyBlobCommitmentCount(body interfaces.ReadOnlyBeaconBlockBody) error {
 	if err != nil {
 		return err
 	}
-	if len(kzgs) > field_params.MaxBlobsPerBlock {
-		return fmt.Errorf("too many kzg commitments in block: %d", len(kzgs))
+	if body.Version() >= version.Electra {


This change is related to: ethereum/consensus-specs#4023
It's a place holder to make sure we can pass spec test, it'll be superseded by #14678

terencechain · 2024-12-17T22:42:56Z

beacon-chain/core/electra/consolidations.go

@@ -78,7 +77,7 @@ func ProcessPendingConsolidations(ctx context.Context, st state.BeaconState) err
 		if err != nil {
 			return err
 		}
-		b := min(validatorBalance, helpers.ValidatorMaxEffectiveBalance(sourceValidator))
+		b := min(validatorBalance, sourceValidator.EffectiveBalance())


This is related to: ethereum/consensus-specs#4040
Also updated spec test above

terencechain · 2024-12-17T22:44:19Z

beacon-chain/core/validators/validator_test.go

@@ -217,6 +217,7 @@ func TestSlashValidator_OK(t *testing.T) {
 }

 func TestSlashValidator_Electra(t *testing.T) {
+	helpers.ClearCache()


Running TestSlashValidator_Electra by itself passes but running the entire package will fail because previous test uses cache. This wasn't an issue before but now becomes an issue because shuffling is different after Electra

terencechain · 2024-12-17T22:46:04Z

beacon-chain/core/electra/consolidations.go

@@ -253,7 +248,7 @@ func ProcessConsolidationRequests(ctx context.Context, st state.BeaconState, req
 		}

 		// Target validator must have their withdrawal credentials set appropriately.
-		if !helpers.HasExecutionWithdrawalCredentials(tgtV) {
+		if !helpers.HasCompoundingWithdrawalCredential(tgtV) {


This is related to ethereum/consensus-specs#4020

Fix tests Fix tests

Fix test stream events by properly set effective balance

potuz · 2024-12-19T18:18:05Z

beacon-chain/core/altair/sync_committee.go

+			randomByteSlice := bytesutil.PadTo(randomByte[offset:offset+2], 8)
+			randomValue := binary.LittleEndian.Uint64(randomByteSlice)


A matter of taste but I kinda read better this without the allocation

randomValue := uint64(randomByte[offset]) | uint64(randomByte[offset+1])<<8

potuz · 2024-12-19T18:22:40Z

beacon-chain/core/altair/sync_committee.go

+			// Use the preallocated seed buffer
+			binary.LittleEndian.PutUint64(seedBuffer[len(seed):], uint64(i/32))
+			randomByte := hashFunc(seedBuffer)[i%32]
+			if effectiveBal*fieldparams.MaxRandomValue >= cfg.MaxEffectiveBalance*uint64(randomByte) {


Should this be MaxRandomByte?

Suggested change

if effectiveBal*fieldparams.MaxRandomValue >= cfg.MaxEffectiveBalance*uint64(randomByte) {

if effectiveBal*maxRandomByte >= cfg.MaxEffectiveBalance*uint64(randomByte) {

Fix tests Fix tests

Fix test stream events by properly set effective balance

prestonvanloon · 2024-12-20T16:45:23Z

CHANGELOG.md

@@ -82,6 +82,7 @@ Notable features:
 - Save light client updates and bootstraps in DB.
 - Added more comprehensive tests for `BlockToLightClientHeader`. [PR](https://github.com/prysmaticlabs/prysm/pull/14699)
 - Added light client feature flag check to RPC handlers. [PR](https://github.com/prysmaticlabs/prysm/pull/14736)
+- Add field param placeholder for Electra blob target and max to pass spec tests.


Please add this to the unreleased section

prestonvanloon · 2024-12-20T16:45:29Z

CHANGELOG.md

+- Enforce Compound prefix (0x02) for target when processing pending consolidation request.
+- Limit consolidating by validator's effective balance.
+- Use 16-bit random value for proposer and sync committee selection filter.


Please add this to the unreleased section

prestonvanloon · 2024-12-20T17:13:20Z

beacon-chain/core/electra/churn_test.go

@@ -20,7 +20,7 @@ func createValidatorsWithTotalActiveBalance(totalBal primitives.Gwei) []*eth.Val
 	vals := make([]*eth.Validator, num)
 	for i := range vals {
 		wd := make([]byte, 32)
-		wd[0] = params.BeaconConfig().ETH1AddressWithdrawalPrefixByte


This seems unexpected. Why is it changed?

Related to: ethereum/consensus-specs#4020
In latest spec, consolidation is only allowed if validator has 0x02

…nto alpha10-spec-tests

…-spec-tests

terencechain requested review from prestonvanloon and a team as code owners December 17, 2024 22:36

terencechain requested review from nalepae and saolyn December 17, 2024 22:36

terencechain force-pushed the alpha10-spec-tests branch 3 times, most recently from 02dd398 to 8d74f95 Compare December 17, 2024 22:40

terencechain commented Dec 17, 2024

View reviewed changes

terencechain added the Ready For Review A pull request ready for code review label Dec 17, 2024

terencechain force-pushed the alpha10-spec-tests branch 2 times, most recently from 533e5a7 to bca3668 Compare December 18, 2024 15:47

terencechain added 10 commits December 19, 2024 10:14

Use 16 bit random value

ee39207

enforce 0x02 credentials for consolidations

491498e

Limit consolidating balance by validator effective balance

45c4612

Update max blob commitment size

910f1ce

Fix next sync committee indices

83cbd88

Bytes to little endian

bc47d24

Handle proposer computations in between forks

16473b9

Fix config and tests

511adcc

Fix tests Fix tests

Fix test stream events by properly set effective balance

f553245

Fix test stream events by properly set effective balance

Preallocate buffers to avoid repeated allocations

6448406

potuz reviewed Dec 19, 2024

View reviewed changes

terencechain force-pushed the alpha10-spec-tests branch from 84d6500 to 54f9df0 Compare December 19, 2024 19:47

Potuz's feedback

aee1467

terencechain force-pushed the alpha10-spec-tests branch from 54f9df0 to aee1467 Compare December 19, 2024 21:38

Use 16 bit random value

ed695aa

terencechain added 10 commits December 20, 2024 06:56

enforce 0x02 credentials for consolidations

96dadbd

Limit consolidating balance by validator effective balance

fa39ce4

Update max blob commitment size

acc70e7

Fix next sync committee indices

30a0a37

Bytes to little endian

c9b8eef

Handle proposer computations in between forks

f37f0c2

Fix config and tests

35da875

Fix tests Fix tests

Fix test stream events by properly set effective balance

070eaa0

Fix test stream events by properly set effective balance

Preallocate buffers to avoid repeated allocations

012b224

Potuz's feedback

1a49d61

terencechain force-pushed the alpha10-spec-tests branch from aee1467 to 1a49d61 Compare December 20, 2024 14:56

prestonvanloon reviewed Dec 20, 2024

View reviewed changes

terencechain added 2 commits December 20, 2024 10:01

Merge branch 'alpha10-spec-tests' of github.com:prysmaticlabs/prysm i…

cea2442

…nto alpha10-spec-tests

Fix change log

73d78c9

prestonvanloon previously approved these changes Dec 20, 2024

View reviewed changes

potuz previously approved these changes Dec 23, 2024

View reviewed changes

Merge branch 'develop' of github.com:prysmaticlabs/prysm into alpha10…

1145786

…-spec-tests

terencechain dismissed stale reviews from potuz and prestonvanloon via 1145786 December 23, 2024 14:03

terencechain enabled auto-merge December 23, 2024 14:03

potuz approved these changes Dec 23, 2024

View reviewed changes

prestonvanloon approved these changes Dec 23, 2024

View reviewed changes

terencechain added this pull request to the merge queue Dec 23, 2024

Merged via the queue into develop with commit 6ce6b86 Dec 23, 2024
15 checks passed

terencechain deleted the alpha10-spec-tests branch December 23, 2024 17:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement consensus spec v1.5.0-alpha.10 #14733

Implement consensus spec v1.5.0-alpha.10 #14733

terencechain commented Dec 17, 2024 •

edited

Loading

terencechain Dec 17, 2024

terencechain Dec 17, 2024

terencechain Dec 17, 2024 •

edited

Loading

terencechain Dec 17, 2024

terencechain Dec 17, 2024

potuz Dec 19, 2024

potuz Dec 19, 2024

prestonvanloon Dec 20, 2024

prestonvanloon Dec 20, 2024

prestonvanloon Dec 20, 2024

terencechain Dec 20, 2024

		randomByteSlice := bytesutil.PadTo(randomByte[offset:offset+2], 8)
		randomValue := binary.LittleEndian.Uint64(randomByteSlice)

	if effectiveBalfieldparams.MaxRandomValue >= cfg.MaxEffectiveBalanceuint64(randomByte) {
	if effectiveBalmaxRandomByte >= cfg.MaxEffectiveBalanceuint64(randomByte) {

Implement consensus spec v1.5.0-alpha.10 #14733

Implement consensus spec v1.5.0-alpha.10 #14733

Conversation

terencechain commented Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

terencechain Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

terencechain commented Dec 17, 2024 •

edited

Loading

terencechain Dec 17, 2024 •

edited

Loading