Consolidate ApplyDeposit for Altair and Electra
#14535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
rm-electra-process-deposits
branch
2 times, most recently
from
28e6d53
to
94c1788
Compare
terencechain
force-pushed
the
rm-electra-process-deposits
branch
from
94c1788
to
b0659d0
Compare
james-prysm
reviewed
Oct 15, 2024
| // withdrawable_epoch=FAR_FUTURE_EPOCH, | ||
| // effective_balance=effective_balance, | ||
| // ) | ||
| func GetValidatorFromDeposit(pubKey []byte, withdrawalCredentials []byte, amount uint64) *ethpb.Validator { |
There was a problem hiding this comment.
this should have forking logic as it lives in the blocks package, it was updated in electra
Redidacove
reviewed
Oct 15, 2024
| @@ -23,5 +23,5 @@ func blockWithDeposit(ssz []byte) (interfaces.SignedBeaconBlock, error) { | |||
| } | |||
|
|
|||
| func RunDepositTest(t *testing.T, config string) { | |||
There was a problem hiding this comment.
I have a doubt if we are making it common for all forks shouldn't we keep the tests for it inside blocks pkg only as it doesn't depends on version ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code was completely duplicated:
ProcessDeposits(moved to block package)ProcessDeposit(moved to block package)ApplyDeposit(moved to block package)This PR consolidates
ApplyDepositbetween Altair and Electra to eliminate duplicated code. TheApplyDepositfunction processes a deposit in the beacon chain by checking if a validator exists based on their public key. If the validator exists and the beacon state version is before Electra, it increases their balance. If the validator doesn't exist, it validates the deposit signature (unless all signatures have already been verified) and adds the validator to the registry if valid. For Electra and later versions, it processes deposits by appending them to the pending deposits list, without directly increasing balances.