Better attestation packing for Electra #14534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
force-pushed
the
electra-better-packing
branch
from
756d852 to
fd2501b
Compare
# Conflicts: # CHANGELOG.md
rkapka
commented
Oct 14, 2024
| @@ -231,7 +259,6 @@ func (a proposerAtts) sortBySlotAndCommittee() (proposerAtts, error) { | |||
| type slotAtts struct { | |||
| candidates map[primitives.CommitteeIndex]proposerAtts | |||
| selected map[primitives.CommitteeIndex]proposerAtts | |||
| leftover map[primitives.CommitteeIndex]proposerAtts | |||
There was a problem hiding this comment.
We ignore leftover attestations, so this is not needed.
rkapka
added
Ready For Review
Enhancement
# Conflicts: # CHANGELOG.md
rkapka
force-pushed
the
electra-better-packing
branch
from
41e1d96 to
3402608
Compare
rkapka
force-pushed
the
electra-better-packing
branch
from
5f27d17 to
b2d96d8
Compare
rkapka
force-pushed
the
electra-better-packing
branch
from
a7258d3 to
41dd445
Compare
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
terencechain
approved these changes
Nov 25, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Our current packing algorithm for Electra is very non-optimal and was only supposed to be used in devnets, where the network is very small and communication between nodes is very reliable, resulting in a small number of aggregates. This algorithm creates only one on-chain attestation per an
attestation_data+committeecombination. It means that if there are two aggregates for the same data and committee, the one with less attestation bits will always be dropped, even if it could be packed into a block.The new algorithm loops through aggregates until all of them are included in an on-chain attestation.
Acknowledgements