Prysm rpc: submit signed execution payload header #14441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested review from
nalepae,
rauljordan and
saolyn
and removed request for
a team
terencechain
force-pushed
the
submit-signed-header
branch
3 times, most recently
from
3692c44
to
c486002
Compare
terencechain
force-pushed
the
submit-signed-header
branch
from
c486002
to
85c833b
Compare
jihoonsong
approved these changes
Sep 17, 2024
| @@ -31,6 +32,17 @@ func (vs *Server) SubmitSignedExecutionPayloadEnvelope(ctx context.Context, env | |||
| return nil, nil | |||
| } | |||
|
|
|||
| // SubmitSignedExecutionPayloadHeader submits a signed execution payload header to the beacon node. | |||
| func (vs *Server) SubmitSignedExecutionPayloadHeader(ctx context.Context, h *enginev1.SignedExecutionPayloadHeader) (*emptypb.Empty, error) { | |||
There was a problem hiding this comment.
If I understood correctly, this is a method within beacon node and is intended to be called by validator, right?
potuz
reviewed
Sep 18, 2024
Comment on lines
38
to
40
| if vs.TimeFetcher.CurrentSlot() != h.Message.Slot && vs.TimeFetcher.CurrentSlot() != h.Message.Slot-1 { | ||
| return nil, status.Errorf(codes.InvalidArgument, "invalid slot: current slot %d, got %d", vs.TimeFetcher.CurrentSlot(), h.Message.Slot) |
There was a problem hiding this comment.
There are three calls for vs.TimeFetcher.CurrentSlot() in these two lines, can we change this to
Suggested change
| if vs.TimeFetcher.CurrentSlot() != h.Message.Slot && vs.TimeFetcher.CurrentSlot() != h.Message.Slot-1 { | |
| return nil, status.Errorf(codes.InvalidArgument, "invalid slot: current slot %d, got %d", vs.TimeFetcher.CurrentSlot(), h.Message.Slot) | |
| currSlot := vs.TimeFetcher.CurrentSlot() | |
| if currSlot > h.message.Slot || currSlot + 1 < h.message.Slot { | |
| return nil, status.Errorf(codes.InvalidArgument, "invalid slot: current slot %d, got %d", currSlot, h.Message.Slot) |
terencechain
force-pushed
the
submit-signed-header
branch
from
c4b17ef
to
329e685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Prysm RPC endpoint for the validator to submit a signed execution payload header. The beacon node will cache the signed execution payload header, with the condition that the slot must be the current slot, and only one header will be cached, updating to the latest one