Update Deps For Capella #12067
Merged
Update Deps For Capella #12067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
previously approved these changes
Mar 1, 2023
rkapka
previously approved these changes
Mar 1, 2023
|
Blocked by bazel-contrib/rules_go#3411 |
|
Unblocked by 19c3741 |
prestonvanloon
previously approved these changes
Mar 1, 2023
|
Tests fail for //beacon-chain/execution:go_default_test
|
|
It seems like this was because of this PR: |
prestonvanloon
approved these changes
Mar 2, 2023
I dont think so, this seems like it was because the geth team fixed a long-standing bug and our test relied on that bug to pass. I don't expect this to break anymore. In anycase this test is testing a function that is cosmetic and deprecated after the merge, so not a big issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Dependency Update
What does this PR do? Why is it needed?
This updates our go-ethereum dependency to v1.11.2 and lighthouse dependency to v3.5.0 . These are capella compatible versions for both clients which should allow us to test them out properly in our E2E tests.
Which issues(s) does this PR fix?
N.A
Other notes for review