Fix Batch Requesting Of Headers #11982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Nethermind in their v1.16.x version introduced stricter limiting of json-rpc requests and this led to issues with prysm as detailed here: NethermindEth/nethermind#5208
Upon further investigation it was revealed that nethermind had the same header request limit as prysm and despite that, the above error was still being encountered. After some debugging, it was determined that prysm had an off-by-1 in the batch header requesting logic. This PR corrects that bug.
Which issues(s) does this PR fix?
N.A
Other notes for review