/eth/v1/beacon/blinded_blocks/{block_id} API endpoint
#11538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
terencechain
reviewed
Oct 4, 2022
| bellatrixBlk, err := blk.PbBellatrixBlock() | ||
| if err == nil { | ||
| if bellatrixBlk == nil { | ||
| return nil, status.Errorf(codes.Internal, "Nil block") |
There was a problem hiding this comment.
Suggested change
| return nil, status.Errorf(codes.Internal, "Nil block") | |
| return nil, status.Error(codes.Internal, "Nil block") |
Comment on lines
+880
to
+891
| blindedBlkInterface, err := blk.ToBlinded() | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.Internal, "Could not convert block to blinded block: %v", err) | ||
| } | ||
| blindedBellatrixBlock, err := blindedBlkInterface.PbBlindedBellatrixBlock() | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.Internal, "Could not get signed beacon block: %v", err) | ||
| } | ||
| v2Blk, err := migration.V1Alpha1BeaconBlockBlindedBellatrixToV2Blinded(blindedBellatrixBlock.Block) | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.Internal, "Could not get signed beacon block: %v", err) | ||
| } |
There was a problem hiding this comment.
This endpoint is requesting a blinded block, so we must convert a bellatrix block to blinded format
rauljordan
reviewed
Oct 4, 2022
There was a problem hiding this comment.
I reviewed @rkapka and aside from the minor suggestions from Terence, it looks good to merge
terencechain
previously approved these changes
Oct 7, 2022
# Conflicts: # beacon-chain/rpc/apimiddleware/endpoint_factory.go # beacon-chain/rpc/apimiddleware/structs.go
rauljordan
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implements fetching blinded blocks through the Beacon API as described in ethereum/beacon-APIs#241. See also https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlindedBlock.
Other notes for review
This PR also adds missing
ExecutionOptimisticfield to the response of non-blinded SSZ version and improves a few small things in existing grpc endpoints.