Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Informative Errors on Execution Client Connection Issues #11359

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Informative Errors on Execution Client Connection Issues #11359

merged 3 commits into from
Aug 30, 2022

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Aug 30, 2022 •
edited
Loading

This PR adds informative errors in case a user runs into the following scenarios:

  1. Not authenticating their HTTP connection to their execution client with a JWT token, which will return 401 unauthorized errors upon checking the chain ID of the execution client via JSON-RPC
  2. Not connecting to their execution client on the engine port, which will lead to "not found" errors when connecting via the usual JSON-RPC at 8545

Tested in interop mode and is a lot friendlier now than it was before.

@rauljordan rauljordan requested a review from a team as a code owner August 30, 2022 18:02
@prylabs-bulldozer prylabs-bulldozer bot merged commit 0725905 into develop Aug 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-err-auth branch August 30, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

@symbolpunk symbolpunk Awaiting requested review from symbolpunk symbolpunk is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauljordan @terencechain