Restore --no-history CLI flag functionality
#2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--no-history` option was almost ten years ago, in db64985, when the object at `Pry.config.history` was still an `OpenStruct` (added in e1d9763, just over ten years ago!). The contract on the configuration history object changed in e5556a2. This commit brings the `--no-history` option up to date with that refactor.
|
Looks great, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--no-historyoption was almost ten years ago, in db64985, when the object atPry.config.historywas still anOpenStruct(added in e1d9763, just over ten years ago!). The contract on the configuration history object changed in e5556a2. This commit brings the--no-historyoption up to date with that refactor.This is essentially a duplicate of #2143, but that appears to be abandoned.