Skip to content

Fix issue #1660, pry output error in base_helpers #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2017
Merged

Fix issue #1660, pry output error in base_helpers #1661

merged 1 commit into from
Oct 13, 2017

Conversation

robsliwi
Copy link
Contributor

Like described in
#1660 a simple
change fixes pry

@robsliwi
Fix pry output error in base_helpers
08df0b4 
Like described in
pry#1660 a simple
change fixes pry
@0x1eef 0x1eef self-assigned this Oct 13, 2017
@0x1eef 0x1eef self-requested a review October 13, 2017 21:04
0x1eef
0x1eef approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@0x1eef 0x1eef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@0x1eef 0x1eef merged commit 775beea into pry:master Oct 13, 2017
@0x1eef
Copy link
Contributor

0x1eef commented Oct 13, 2017 •
edited
Loading

Thanks a lot!
I tried checking out your code locally but it seemed quite hard to do via GitHub.

$ git fetch github/robsilwi # Your branch did not appear.
$ git pull github/robsliwi fix/pry_io_error
fatal: Couldn't find remote ref fix/pry_io_error

No worries. Thanks for the contribution.

@banister
Copy link
Member

@R-obert remember it's 0-9-11-stable that is our release branch atm.....maybe we should just reset master to this to avoid confusion?

banister pushed a commit that referenced this pull request Oct 18, 2017
@robsliwi @banister
Fix pry output error in base_helpers (#1661)
cd0283d 
Like described in
#1660 a simple
change fixes pry
@0x1eef 0x1eef mentioned this pull request Oct 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@0x1eef 0x1eef 0x1eef approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@0x1eef 0x1eef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robsliwi @0x1eef @banister