Skip to content

Commit

Permalink
PR c++/84449
Browse files Browse the repository at this point in the history
	* tree.c (bot_manip): If build_cplus_new or break_out_target_exprs
	returns error_mark_node, return it immediately.
	(break_out_target_exprs): If cp_walk_tree with bot_manip returns
	error_mark_node, return error_mark_node.

	* g++.dg/cpp0x/constexpr-84449.C: New test.


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@257839 138bc75d-0d04-0410-961f-82ee72b054a4
  • Loading branch information
jakub committed Feb 20, 2018
1 parent 16335c2 commit e6df320
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 1 deletion.
6 changes: 6 additions & 0 deletions gcc/cp/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
2018-02-20 Jakub Jelinek <jakub@redhat.com>

PR c++/84449
* tree.c (bot_manip): If build_cplus_new or break_out_target_exprs
returns error_mark_node, return it immediately.
(break_out_target_exprs): If cp_walk_tree with bot_manip returns
error_mark_node, return error_mark_node.

PR c++/84455
* pt.c (tsubst_lambda_expr): If not nested, increment temporarily
function_depth to avoid GC during finish_lambda_function.
Expand Down
7 changes: 6 additions & 1 deletion gcc/cp/tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -2896,6 +2896,8 @@ bot_manip (tree* tp, int* walk_subtrees, void* data)
{
u = build_cplus_new (TREE_TYPE (t), TREE_OPERAND (t, 1),
tf_warning_or_error);
if (u == error_mark_node)
return u;
if (AGGR_INIT_ZERO_FIRST (TREE_OPERAND (t, 1)))
AGGR_INIT_ZERO_FIRST (TREE_OPERAND (u, 1)) = true;
}
Expand All @@ -2913,6 +2915,8 @@ bot_manip (tree* tp, int* walk_subtrees, void* data)
(splay_tree_value) TREE_OPERAND (u, 0));

TREE_OPERAND (u, 1) = break_out_target_exprs (TREE_OPERAND (u, 1));
if (TREE_OPERAND (u, 1) == error_mark_node)
return error_mark_node;

/* Replace the old expression with the new version. */
*tp = u;
Expand Down Expand Up @@ -3025,7 +3029,8 @@ break_out_target_exprs (tree t)
target_remap = splay_tree_new (splay_tree_compare_pointers,
/*splay_tree_delete_key_fn=*/NULL,
/*splay_tree_delete_value_fn=*/NULL);
cp_walk_tree (&t, bot_manip, target_remap, NULL);
if (cp_walk_tree (&t, bot_manip, target_remap, NULL) == error_mark_node)
t = error_mark_node;
cp_walk_tree (&t, bot_replace, target_remap, NULL);

if (!--target_remap_count)
Expand Down
3 changes: 3 additions & 0 deletions gcc/testsuite/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
2018-02-20 Jakub Jelinek <jakub@redhat.com>

PR c++/84449
* g++.dg/cpp0x/constexpr-84449.C: New test.

PR c++/84455
* g++.dg/cpp0x/lambda/lambda-ice26.C: New test.

Expand Down
14 changes: 14 additions & 0 deletions gcc/testsuite/g++.dg/cpp0x/constexpr-84449.C
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// PR c++/84449
// { dg-do compile { target c++11 } }

struct A
{
constexpr A (int) {}
~A () = delete;
};

struct B
{
A a;
constexpr B () : a (0) {} // { dg-error "use of deleted function" }
};

0 comments on commit e6df320

Please sign in to comment.