Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs small refactors and performance-oriented tweaks across CsToml’s serializer/parser internals, plus adds a new BenchmarkDotNet benchmark to measure writer performance.
Changes:
- Adds
TomlTableNodeDictionary.GetOrAddIfNotFound()and switchesTomlTableNodechild-node creation to use it. - Optimizes string escaping detection and double formatting checks by using
SearchValues<byte>. - Adds a new
Utf8TomlDocumentWriterBenchmarkand updates benchmark code cleanup.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CsToml/Values/TomlTableNodeDictionary.cs | Adds GetOrAddIfNotFound() and a result struct for table-node lookup/add. |
| src/CsToml/Values/TomlTableNode.cs | Refactors child-node lookup/add to use the new dictionary API; minor readability tweak. |
| src/CsToml/Values/TomlString.cs | Uses SearchValues<byte> to quickly detect whether escaping is needed when writing basic strings. |
| src/CsToml/Utf8TomlDocumentWriter.cs | Uses SearchValues<byte> for the “has decimal/exponent” check in WriteDouble. |
| src/CsToml/CsTomlReader.cs | Adjusts whitespace handling by explicitly advancing on space/tab before skipping remaining whitespace. |
| src/CsToml.Generator/CsToml.Generator.csproj | Updates generator LangVersion from 12 to 14. |
| sandbox/Benchmark/Benchmark/Utf8TomlDocumentWriterBenchmark.cs | Adds a new benchmark for writer/string serialization throughput. |
| sandbox/Benchmark/Benchmark/ClassSerializationBenchmark.cs | Simplifies a type reference for the snake_case benchmark model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some minor refactoring.
Change:
LangVersionupdate 12 to 14TomlTableNodeDictionary.GetOrAddIfNotFoundSearchValues<byte>when serializingTomlStringSearchValuesinUtf8TomlDocumentWriter.WriteDouble