Fix invalid scheme with iOS 14.5

[SimonIT]

PR Checklist

• The PR title follows our guidelines: https://github.com/proyecto26/react-native-inappbrowser/blob/master/CONTRIBUTING.md#pull-request-process.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• All existing tests are passing
• Tests for the changes are included

What is the current behavior?

Exception with invalid scheme is thrown

What is the new behavior?

The scheme will be escaped by default

Fixes/Implements/Closes #256

I tried testing this change with the example but there occurred just more errors. I fixed the flipper and babbel one and then gave up.
I hope everything will work. I'm not very familiar with iOS so don't bash me if I made something wrong. I just need the fix.

[jdnichollsc]

Hello mate, thanks for your collaboration

Do you know if this change is a breaking change for old versions of iOS? :)

[SimonIT]

Hi,
I quick researched the addingPercentEncoding method. I came to the result that the method is available since iOS 7.0+. I don't know if a version check is needed. I couldn't find the iOS minimum version for this lib.
I couldn't find information since when it is possible to use an escaped callbackURLScheme

[SimonIT]

I just researched the iOS version requirement for react native: iOS 7.0+ is required since 0.14.0 which came out 2015 (source facebook/react-native@e2841c0). So I would say that this is pretty safe

[jdnichollsc]

Awesome, thanks for letting me know! @maoapp is going to help us with a new release including these changes <3

[waltershub]

@jdnichollsc why isn't this merged yet

[jdnichollsc]

I'm busy, maybe @maoapp too 🙂
Let me confirm you 👍

[exception]

Similar issue resolved here https://github.com/auth0/react-native-auth0/pull/369/files, this was a breaking change with iOS 14.5

[hszouszcz]

Let me gently poke you one more time (:

[ftlno]

Any chance of this getting merged soon?

[janicduplessis]

I think using [[NSURL alloc] initWithString:redirectURL].scheme; to extract only the scheme part from the URL would be a better fix, like what was done in https://github.com/auth0/react-native-auth0/pull/369/files

[jdnichollsc]

@SimonIT what do you think? 🙂

[SimonIT]

If it works, why not. I personally don't see the benefit of it

[SimonIT]

Just tried it myself, seem to work fine

[janicduplessis]

The api expects only the scheme part of the URL so I think it is better to do that instead of encoding the slashes to bypass the validation check.

[jdnichollsc]

Agree! Please let me know folks <3
PD: In the meantime, do you know if this issue is fixed by using encodeURIComponent('my-scheme://') from JS side? 🤔

[SimonIT]

I actually don't know and I can't try it, because I'm not directly using this lib. Another lib I'm using is using this lib. That's why this fix is so important for me.
By the way, I updated it to only use the scheme

[PhilippBurgk]

If someone has a direct dependency and needs this fix, you can do the following:

Change the dependency to the commit hash (package.json).
"react-native-inappbrowser-reborn": "https://github.com/SimonIT/react-native-inappbrowser#b35ef11f48c072971ec61049dc1370678db2dac1",

[zachnicoll]

Any updates on getting this merged?

[akubara]

Agree! Please let me know folks <3
PD: In the meantime, do you know if this issue is fixed by using encodeURIComponent('my-scheme://') from JS side? thinking

Yep, Platform.OS === 'android' ? deeplinkUri : encodeURIComponent(redirectUri), works on ios 14.5+

[rainyer]

Any updates on getting this merged?

+1

[jdnichollsc]

I'm going to publish this change today, thanks folks! <3

[markl-vesper]

I'm getting this error on 3.6.3

Update- I think what happened there was that as part of testing the app with or without the browser and different versions a pod install might have been missed

But after removing InnAppBrowser from package.json, yarn install, pod install, add back to package.json, yarn install, pod install, react-native run-ios

Still getting the same error

Update- Looks like one final run-ios sorted it out. Odd but it seems to be working now