Skip to content

Fix Xcode 12 compatibility. #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix Xcode 12 compatibility. #192

merged 1 commit into from
Oct 14, 2020

Conversation

jinshin1013
Copy link
Contributor

What is the current behavior?

The iOS is depending on React Pod

What is the new behavior?

This fixes the Xcode 12 compatibility issue. More info can be found here facebook/react-native#29633 (comment)

This fixes #187

@pxmage
Copy link

pxmage commented Oct 3, 2020

Hope this will be merged soon! Thank you!

@jdnichollsc
Copy link
Member

What versions of React Native are supported with this change?

@jdnichollsc
Copy link
Member

Let me generate a new version before and then publish this change as a minor fix :)

@jinshin1013
Copy link
Contributor Author

@jdnichollsc Hey! According to the comment facebook/react-native#29633 (comment) React-Core has always been "correct" dependency so I believe all version of RN are supported with the change? Don't quote me on this though 😅

@jdnichollsc jdnichollsc merged commit 2d3f3bc into proyecto26:develop Oct 14, 2020
@jdnichollsc
Copy link
Member

Thanks for your help! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RNInAppBrowser becomes 'undefined' after upgraded to Xcode 12
3 participants