Skip to content

fixing mergeExtDexDebugAndroidTest task #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

mynameisguy
Copy link
Contributor

@mynameisguy mynameisguy commented Mar 14, 2020

running mergeExtDexDebugAndroidTest task failed. fixed it as described here

PR Checklist

What is the current behavior?

Tried to run detox build for android in my project.
This library failed with:

> Transform artifact browser.aar (androidx.browser:browser:1.3.0-alpha01) with DexingTransform
AGPBI: {"kind":"error","text":"Static interface methods are only supported starting with Android N (--min-api 24): androidx.browser.trusted.TrustedWebActivityDisplayMode androidx.browser.trusted.TrustedWebActivityDisplayMode.fromBundle(android.os.Bundle)","sources":[{}],"tool":"D8"}

> Task :react-native-inappbrowser-reborn:mergeExtDexDebugAndroidTest FAILED

What is the new behavior?

Now I can run detox build in my root project and it doesn't fail.

@jdnichollsc
Copy link
Member

I can't see any other package from the community using that configuration https://github.com/react-native-community, it looks like you need to include that from your project itself

@JavanHuang
Copy link

Hi all!

While configuring the detox setup for my own project, I also chanced upon this error while trying to build the detox test configurations with detox build -c <configuration-name> .

I've already included the following configuration in my own project and I'm still unable to successfully build the detox test configurations.

android {
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
}

This configuration is also being used in packages from the react-native-community, and examples are react-native-community/lottie-react-native and react-native-webview

Perhaps we could try including the configuration in this package?

@jdnichollsc
Copy link
Member

jdnichollsc commented Jun 27, 2020

@mynameisguy can you update please the branch of this PR to develop instead of master? Thanks for your help! <3

@mynameisguy mynameisguy changed the base branch from master to develop June 27, 2020 07:55
@mynameisguy
Copy link
Contributor Author

sure! done

@jdnichollsc jdnichollsc merged commit ff64125 into proyecto26:develop Jun 27, 2020
@jdnichollsc
Copy link
Member

Thanks! <3

phuongwd pushed a commit to phuongwd/react-native-inappbrowser that referenced this pull request Jul 31, 2020
fixing mergeExtDexDebugAndroidTest task
@codetheweb
Copy link

@jdnichollsc it looks like this patch isn't published yet, do you have plans to push a new version to NPM soon?

@jdnichollsc
Copy link
Member

@codetheweb sorry folks for the delay, let me create the new release during this next weekend! 👍

@JoaoBGusmao
Copy link

@jdnichollsc It would be nice if you could take some time to publish this change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants