Skip to content

Disable swipe to dismiss gesture for modal #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Disable swipe to dismiss gesture for modal #134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76b643
Disable swipe to dismiss gesture for modal
yilinjuang Jan 1, 2020
ce0f8be
Fix
yilinjuang Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ios/RNInAppBrowser.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@ + (BOOL)requiresMainQueueSetup
UINavigationController *safariHackVC = [[UINavigationController alloc] initWithRootViewController:safariVC];
[safariHackVC setNavigationBarHidden:true animated:false];

// To disable "Swipe to dismiss" gesture which sometimes causes a bug where `safariViewControllerDidFinish`
// is not called.
safariVC.modalPresentationStyle = UIModalPresentationOverFullScreen;
safariHackVC.modalPresentationStyle = [self getPresentationStyle: modalPresentationStyle];
if(animated) {
safariHackVC.modalTransitionStyle = [self getTransitionStyle: modalTransitionStyle];
Expand Down