Fix react and react-native deps

[friederbluemle]

Use fixed versions for react and react-native.

One version of react-native is always tightly coupled with exactly one version of react. They can't go out of sync, or things will likely break.

[jdnichollsc]

This package don't need react as dependency, and for that reason don't care the version used for React Native 🙂

[jdnichollsc]

On the other hand we're using gitflow now, so please create PR to develop branch 👍

[friederbluemle]

I agree there is no direct dependency on react in the source code. But there is one (of course) on react-native. And react-native has a peer dependency on react. Without declaring it as a dev dependency, it would be missing sources when resolving types located in the react package (during development).

[friederbluemle]

I've changed the base branch and rebased onto develop. 👍

[jdnichollsc]

I mean, what script of the package requires that dependency? We're using the example project to debug the plugin and we don't need that :)

[friederbluemle]

I can remove it if you really want to.. It will cause a warning when installing dependencies:

warning " > react-native@0.60.0" has unmet peer dependency "react@16.8.6".

I have a bunch of other branches locally, including one related to CI which builds the library code in isolation (no other code required), to be able to detect and fix issues. Having a complete description of the project dependency model be one of the prerequisites.

[friederbluemle]

Hi @jdnichollsc - Are you no longer interested in the fixes here?

[jdnichollsc]

@friederbluemle if you want, please fix the merge issues of these devDependencies and I can merge that

[friederbluemle]

@jdnichollsc Sure thing! Can you please reopen the PR, and I'll push the updated branch with conflicts resolved.

[friederbluemle]

Thanks! Updated 👍

[jdnichollsc]

Thanks to you!