-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ABI to Proxy-Wasm ABI v0.2.1. #64
Conversation
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- it's great to be able to use the whole new ABI. Thanks.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Hi @PiotrSikora , I am curious about the status of this PR. Do you have any idea when this PR will be merged, or is there some kind of blocker? By the way, I would also appreciate it if you could tell me if there is a written specification of ABI v0.2.0/1 apart from the implementation (https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/master/src/wasm.cc#L128-L140). |
There is no blocker, it should have been merged months ago, but I wanted to add one more change before breaking API, and it felt behind the schedule. It was quite silly in hindsight. I'll try to make that change over the weekend, but even if it doesn't happen, I'll merge this PR on Monday. Feel free to ping me here if it's not done by then.
Nope, sorry. |
Thank you so much for your quick answer! It helps a lot! |
@PiotrSikora just wanted to follow up here on the plans for merge. Appreciate the hard work on this |
@PiotrSikora hey wanted to check in if there are any blockers on this. Would be great to get a release out when you can. |
@jcrugzz thanks for the nudge. I want to spin one more 0.1.x release before merging this, since it's a breaking change. The new release was mostly blocked on the gRPC support (merged a few days ago), but there are a few small fixes that I want get in... It should be done by the end of this week, and I'll merge this afterwards. |
@PiotrSikora Thanks for the response, appreciate your work here |
@PiotrSikora hey just checking in here. I know how busy things can be so just seeing where we are at. All the best |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora piotrsikora@google.com