Skip to content

Add support for gRPC streams. #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2021
Merged

Conversation

Shikugawa
Copy link
Contributor

@Shikugawa Shikugawa commented Apr 13, 2021

Add gRPC stream support for Rust SDK. It includes any workaround around callout token table caused by #100 is not landed to master.

Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a style-pass, otherwise looks fine (sans missing get_grpc_stream_message).

Also, please mark this PR as ready for review when it's ready.

Signed-off-by: Shikugawa <Shikugawa@gmail.com>
@Shikugawa Shikugawa marked this pull request as ready for review May 9, 2021 15:02
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
@PiotrSikora PiotrSikora changed the title gRPC stream support Add support for gRPC streams. May 19, 2021
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@PiotrSikora PiotrSikora merged commit c94f6e4 into proxy-wasm:master May 19, 2021
@Shikugawa Shikugawa deleted the grpc-stream branch May 19, 2021 14:26
@PiotrSikora PiotrSikora mentioned this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants