Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Windows from CI #413

Closed
wants to merge 8 commits into from
Closed

Remove Windows from CI #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45ec154
Remove wasmtime windows from CI and test other engines
keithmattix Aug 23, 2024
4b834df
Bump rules_foreign_cc and try all engines on Windows again
keithmattix Aug 24, 2024
e6ac09a
Stash
keithmattix Aug 25, 2024
3344120
Reorganize imports
keithmattix Aug 26, 2024
337701f
Work through the bazel issues
keithmattix Aug 26, 2024
384217e
Try to fix windows long paths
keithmattix Aug 26, 2024
392b3a3
No windows only option....
keithmattix Aug 26, 2024
0a8f6d8
Remove windows from CI
keithmattix Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,13 +260,6 @@ jobs:
os: macos-13
arch: x86_64
action: test
- name: 'Wasmtime on Windows/x86_64'
engine: 'wasmtime'
repo: 'com_github_bytecodealliance_wasmtime'
os: windows-2019
arch: x86_64
action: test
targets: -//test/fuzz/...
- name: 'WAVM on Linux/x86_64'
engine: 'wavm'
repo: 'com_github_wavm_wavm'
Expand Down
16 changes: 14 additions & 2 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
workspace(name = "proxy_wasm_cpp_host")

load("@proxy_wasm_cpp_host//bazel:repositories.bzl", "proxy_wasm_cpp_host_repositories")
load("@proxy_wasm_cpp_host//bazel:repositories.bzl", "proxy_wasm_cpp_host_base_repositories", "proxy_wasm_cpp_host_engine_repositories")

proxy_wasm_cpp_host_repositories()
proxy_wasm_cpp_host_base_repositories()

# Now that rules_foreign_cc was loaded above, we can pull in all of the dependencies we need
load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies")

rules_foreign_cc_dependencies()

# Need to load bazel_features deps as well (now that we've pulled in rules_foreign_cc_deps)
load("@bazel_features//:deps.bzl", "bazel_features_deps")

bazel_features_deps()

proxy_wasm_cpp_host_engine_repositories()

load("@proxy_wasm_cpp_host//bazel:dependencies.bzl", "proxy_wasm_cpp_host_dependencies")

Expand Down
2 changes: 0 additions & 2 deletions bazel/dependencies_import.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@
# limitations under the License.

load("@fuzzing_py_deps//:requirements.bzl", pip_fuzzing_dependencies = "install_deps")
load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies")
load("@rules_fuzzing//fuzzing:repositories.bzl", "rules_fuzzing_dependencies")
load("@v8_python_deps//:requirements.bzl", pip_v8_dependencies = "install_deps")

def proxy_wasm_cpp_host_dependencies_import():
rules_foreign_cc_dependencies()
rules_fuzzing_dependencies()

pip_fuzzing_dependencies()
Expand Down
9 changes: 5 additions & 4 deletions bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository", "new_git_r
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")

def proxy_wasm_cpp_host_repositories():
def proxy_wasm_cpp_host_base_repositories():
# Bazel extensions.

# Update platforms for crate_universe. Can remove when we update Bazel version.
Expand Down Expand Up @@ -69,9 +69,9 @@ def proxy_wasm_cpp_host_repositories():
maybe(
http_archive,
name = "rules_foreign_cc",
sha256 = "bcd0c5f46a49b85b384906daae41d277b3dc0ff27c7c752cc51e43048a58ec83",
strip_prefix = "rules_foreign_cc-0.7.1",
url = "https://github.com/bazelbuild/rules_foreign_cc/archive/0.7.1.tar.gz",
sha256 = "a2e6fb56e649c1ee79703e99aa0c9d13c6cc53c8d7a0cbb8797ab2888bbc99a3",
strip_prefix = "rules_foreign_cc-0.12.0",
url = "https://github.com/bazelbuild/rules_foreign_cc/archive/0.12.0.tar.gz",
)

maybe(
Expand Down Expand Up @@ -157,6 +157,7 @@ def proxy_wasm_cpp_host_repositories():
url = "https://github.com/protocolbuffers/protobuf/releases/download/v3.17.3/protobuf-all-3.17.3.tar.gz",
)

def proxy_wasm_cpp_host_engine_repositories():
# V8 with dependencies.

maybe(
Expand Down
Loading