Skip to content

Add default visibility to Bazel's config_settings. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

keith
Copy link
Contributor

@keith keith commented Oct 6, 2022

In a future version of bazel visibility on config_settings will be enforced. This allows these to be used by anyone.

envoyproxy/envoy#23390

@PiotrSikora
Copy link
Member

@keith could you fix DCO? Thanks!

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@PiotrSikora PiotrSikora changed the title [bazel] Add default visibility to config_settings Add default visibility to Bazel's config_settings. Oct 7, 2022
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit 25d6a99 into proxy-wasm:master Oct 7, 2022
@keith keith deleted the patch-1 branch October 12, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants