Skip to content

Export emscripten_notify_memory_growth(). #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 15, 2022
Merged

Export emscripten_notify_memory_growth(). #288

merged 7 commits into from
Jun 15, 2022

Conversation

chaoqin-li1123
Copy link
Contributor

Signed-off-by: chaoqin-li1123 chaoqinli@google.com

initial
47c7b4b 
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
PiotrSikora
PiotrSikora requested changes May 26, 2022
View reviewed changes
chaoqin-li1123 added 2 commits May 31, 2022 14:46
register callback
3ec1676 
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
fix clang tidy
0e9b3f3 
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
PiotrSikora
PiotrSikora reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test (or at least verify manually that this allows the module requiring momory growth to load)?

remove duplicate code
0d8f177 
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
@chaoqin-li1123
Copy link
Contributor Author

chaoqin-li1123 commented Jun 7, 2022 •
edited
Loading

Could you add a test (or at least verify manually that this allows the module requiring momory growth to load)?

But IIUC, the wasm binary in this repo doesn't build with emscripten.

fix input param type
aa649f3 
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
@chaoqin-li1123
Copy link
Contributor Author

I have verified this manually, the input index should be 32bit.

PiotrSikora
PiotrSikora approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora changed the title export emscripten_notify_memory_growth() function Export emscripten_notify_memory_growth(). Jun 14, 2022
@PiotrSikora PiotrSikora merged commit 73fe589 into proxy-wasm:master Jun 15, 2022
knm3000 pushed a commit to knm3000/proxy-wasm-cpp-host that referenced this pull request Aug 17, 2022
@chaoqin-li1123 @knm3000
Export emscripten_notify_memory_growth(). (proxy-wasm#288)
875388b 
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@mathetake mathetake Awaiting requested review from mathetake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaoqin-li1123 @PiotrSikora