Skip to content

Fix build on Windows. #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 18, 2022
Merged

Fix build on Windows. #260

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9fcbfeb
nullvm: test on Windows.
PiotrSikora Feb 17, 2022
6403eff
review: use "shell: bash".
PiotrSikora Feb 17, 2022
1ecfe48
review: c++17.
PiotrSikora Feb 17, 2022
c5f1fed
review: fix build on some little-endian platforms.
PiotrSikora Feb 17, 2022
c943617
review: use __builtin_bswap32().
PiotrSikora Feb 17, 2022
87356a2
review: pull into proxy_wasm namespace.
PiotrSikora Feb 17, 2022
a2fb9a5
review: debug test data?
PiotrSikora Feb 17, 2022
93395b9
review: fix missed le32toh -> wasmtoh.
PiotrSikora Feb 17, 2022
5f67393
review: add some Bazel hacks to open files?
PiotrSikora Feb 17, 2022
576fdbe
review: try only --enable_runfiles.
PiotrSikora Feb 17, 2022
f0378e1
review: cleanup.
PiotrSikora Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review: debug test data? 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
  • Loading branch information
@PiotrSikora
PiotrSikora committed Feb 17, 2022
commit a2fb9a5dce7d5e1da322b30c2a119e84656f6555
13 changes: 8 additions & 5 deletions .github/workflows/cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,15 @@ jobs:

- name: Mangle build rules to use existing test data
shell: bash
run: >
sed 's/\.wasm//g' test/BUILD > test/BUILD.tmp && mv test/BUILD.tmp test/BUILD;
echo "package(default_visibility = [\"//visibility:public\"])" > test/test_data/BUILD;
for i in $(cd test/test_data && ls -1 *.wasm | sed 's/\.wasm$//g');
do echo "filegroup(name = \"$i\", srcs = [\"$i.wasm\"])" >> test/test_data/BUILD;
run: |
sed 's/\.wasm//g' test/BUILD > test/BUILD.tmp && mv test/BUILD.tmp test/BUILD
echo "package(default_visibility = [\"//visibility:public\"])" > test/test_data/BUILD
for i in $(cd test/test_data && ls -1 *.wasm | sed 's/\.wasm$//g'); do \
echo "filegroup(name = \"$i\", srcs = [\"$i.wasm\"])" >> test/test_data/BUILD; \
done
echo "===== AFTER ====="
git status test/
git diff test/

- name: Bazel build/test
run: >
Expand Down