Skip to content

fix: parse PR number from merge commit message #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergioaten merged 2 commits into from
Mar 19, 2026
Merged

fix: parse PR number from merge commit message #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
616159d
fix(tpl-terragrunt): parse PR number from merge commit message
sergioaten Mar 19, 2026
aa5204d
fix(tpl-terragrunt): avoid shell injection in Write apply summary step
sergioaten Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/tpl-terragrunt.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,11 +301,16 @@ jobs:
run: |
set -euo pipefail

pr_number=$(gh api "/repos/${{ github.repository }}/commits/${{ github.sha }}/pulls" \
--jq '.[0].number // empty')
# Extract PR number from the merge commit message — the /commits/{sha}/pulls
# API endpoint returns empty for merge commits because the merge commit itself
# is not part of the PR's commits, only of main's history.
# Regular merge: "Merge pull request #37 from owner/branch"
# Squash merge: "Some title (#37)"
commit_msg=$(git log -1 --format="%s" HEAD)
pr_number=$(echo "$commit_msg" | grep -oP '(?<=pull request #)\d+|(?<=\(#)\d+(?=\))' | head -1 || true)

if [[ -z "$pr_number" ]]; then
echo "::error::Could not determine PR number for commit ${{ github.sha }}"
echo "::error::Could not determine PR number from commit message: ${commit_msg}"
exit 1
fi

Expand Down Expand Up @@ -366,5 +371,7 @@ jobs:

- name: Write apply summary
if: ${{ always() }}
env:
SUMMARY: ${{ steps.apply_summarize.outputs.summary }}
run: |
echo "${{ steps.apply_summarize.outputs.summary }}" >> "$GITHUB_STEP_SUMMARY"
printf '%s\n' "$SUMMARY" >> "$GITHUB_STEP_SUMMARY"