Fix a race condition on liter_flag #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 14, 2025
jons-pf
force-pushed
the
jons-fix-liter-race
branch
from
818aa2a to
52c98ce
Compare
jons-pf
force-pushed
the
jons-fix-liter-race
branch
from
52c98ce to
b5d285a
Compare
jons-pf
force-pushed
the
graphite-base/386
branch
from
0abeb5a to
5e161a1
Compare
jurasic-pf
force-pushed
the
jons-fix-liter-race
branch
from
b5d285a to
be4b598
Compare
jurasic-pf
changed the base branch from
graphite-base/386
to
jurasic/fix-mac-ci
jurasic-pf
approved these changes
Sep 14, 2025
graphite-app
bot
changed the base branch from
jurasic/fix-mac-ci
to
graphite-base/386
graphite-app
bot
force-pushed
the
graphite-base/386
branch
from
648928b to
f08ba94
Compare
graphite-app
bot
force-pushed
the
jons-fix-liter-race
branch
from
be4b598 to
623722b
Compare
graphite-app
bot
force-pushed
the
jons-fix-liter-race
branch
from
623722b to
4ce29e4
Compare
Merge activity
|
It is read in each thread in the for loop condition check, but written only from one thread within SolveEquilibriumLoop. This PR introduces a barrier to protect the read from liter_flag within the for loop condition from the write within SolveEquilibriumLoop.
graphite-app
bot
force-pushed
the
jons-fix-liter-race
branch
from
4ce29e4 to
9bf8324
Compare
jungdaesuh
pushed a commit
to jungdaesuh/vmecpp
that referenced
this pull request
Dec 1, 2025
It is read in each thread in the for loop condition check, but written only from one thread within SolveEquilibriumLoop. This PR introduces a barrier to protect the read from liter_flag within the for loop condition from the write within SolveEquilibriumLoop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is read in each thread in the for loop condition check, but written
only from one thread within SolveEquilibriumLoop.
This PR introduces a barrier to protect the read from liter_flag within
the for loop condition from the write within SolveEquilibriumLoop.