[WOut] Add currumnc, currvmnc (untested) #235
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2025
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 9, 2025
This was referenced Apr 9, 2025
Closed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const Eigen::VectorXi& xm_nyq, | ||
| const Eigen::VectorXi& xn_nyq, | ||
| RowMatrixXd& currumnc, RowMatrixXd& currvmnc) { | ||
| const int ns = bsubsmns.rows(); |
There was a problem hiding this comment.
warning: narrowing conversion from 'Index' (aka 'long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
const int ns = bsubsmns.rows();
^
jurasic-pf
force-pushed
the
jurasic-wout-compatibility
branch
from
dd2289d to
99a2d11
Compare
jurasic-pf
force-pushed
the
jurasic-wout-currumnc
branch
from
322257d to
38fb975
Compare
jurasic-pf
changed the title
jurasic-pf
force-pushed
the
jurasic-wout-compatibility
branch
from
99a2d11 to
d434009
Compare
jurasic-pf
force-pushed
the
jurasic-wout-currumnc
branch
from
38fb975 to
0e257b7
Compare
jurasic-pf
changed the base branch from
jurasic-wout-compatibility
to
graphite-base/235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.