chore(s3): create class and refactor #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
provider/aws
jfagoagas
commented
Jul 22, 2024
Comment on lines
300
to
312
| # TODO: fix the above | ||
| # CSV | ||
| # s3_client.upload_file( | ||
| # {args.output_directory} / {output_file + csv_file_suffix}, | ||
| # output_bucket, | ||
| # object_name, | ||
| # ) | ||
| # JSON | ||
| # s3_client.upload_file( | ||
| # {args.output_directory} / {output_file + csv_file_suffix}, | ||
| # output_bucket, | ||
| # object_name, | ||
| # ) |
There was a problem hiding this comment.
@sergargar could you please fix this. We should not use the S3 class anymore here since the QuickInventory has not an output created yet.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4457 +/- ##
==========================================
- Coverage 88.69% 88.58% -0.12%
==========================================
Files 893 893
Lines 27205 27231 +26
==========================================
- Hits 24130 24123 -7
- Misses 3075 3108 +33 ☔ View full report in Codecov by Sentry. |
kagahd
pushed a commit
to kagahd/prowler
that referenced
this pull request
Jul 25, 2024
Co-authored-by: pedrooot <pedromarting3@gmail.com> Co-authored-by: Sergio <sergio@prowler.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are working to decouple all outputs and integrations and now is the turn for the S3 integration to send Prowler's output to a bucket.
Description
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.