feat(ui): GCP org onboarding — Phase 1: canonical contract + lifecycle generalization#12114
Draft
pfe-nazaries wants to merge 5 commits into
Draft
Conversation
added 5 commits
July 23, 2026 17:26
- Rename the browser-mode test suffix to .integration.test - Run babel-plugin-react-compiler in the test build to match production - Mock next/cache so server actions run under Vitest
- Serve deprecated organizational-units and canonical organization-nodes routes over shared fixtures, mirroring the transition-window API - Cover organizations, secrets, discovery, apply, connection and deletion
- Page-level harness mounting the providers view with MSW wiring - Semantic methods for the wizard flow and table row actions
- Cover onboarding happy path, blocked accounts, retry and skip - Cover providers-page grouping, edit-name, credentials and deletion
…(Phase 1) Migrate the organizations data layer to the canonical organization-nodes contract and generalize the onboarding lifecycle by organization type, keeping AWS behavior visually unchanged. GCP support arrives in Phase 2. Implementation: - types: normalized OrgHierarchy (nodes + candidates, kind-discriminated), per-provider wire interfaces, secret/apply payload unions, canonical relation/counter names; drop dead enum values - actions: parameterize org_type, canonical /organization-nodes routes, per-type secret payload builders, discriminated applyDiscovery, and a degraded-fetch error flag - store: persist the normalized hierarchy, candidate naming, discovery-resume fields (discoveryId + status at trigger), provider-agnostic tree rebuild, persist version bump - lifecycle: org-type strategy dispatch in the setup submission chain, kind-driven tree/table rendering (no ID prefixes) - providers page: consume canonical nodes for both org types (drop the hardcoded filter[org_type]=aws), org_type/kind-driven labels, explicit degraded-view signal with a non-blocking notice Testing (integration-first): - new integration coverage: mixed AWS+GCP hierarchy display and degraded-view notice; harness gains a hierarchyStatus mount option - update the pure adapter/submission/store unit tests to the new API; remove unit tests now covered end-to-end by the integration suite - canonical tripwire: MSW handlers stop serving the deprecated /organizational-units routes; full suite stays green Refs: openspec/changes/gcp-organization-onboarding-ui tasks 2.1-2.11
pfe-nazaries
added
the
no-changelog
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pfe-nazaries
force-pushed
the
feature/gcp-organization-ui-phase0
branch
from
July 24, 2026 12:19
a41f159 to
8be8f6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 — canonical organization contract + lifecycle generalization
Second PR in the GCP Organization Onboarding UI chain. Stacked on #12104 (Phase 0) — base branch is
feature/gcp-organization-ui-phase0; review/merge #12104 first.Migrates the organizations data layer to the canonical
organization-nodescontract and generalizes the onboarding lifecycle by organization type. AWS behavior is visually unchanged; GCP support arrives in Phase 2.What changes
OrgHierarchy(nodes + candidates, kind-discriminated), per-provider wire interfaces, secret/apply payload unions, canonical relation/counter names; dead enum values dropped.org_type, canonical/organization-nodesroutes, per-type secret payload builders, discriminatedapplyDiscovery, degraded-fetch signal.discoveryId+ status at trigger), provider-agnostic tree rebuild, persist-version bump.filter[org_type]=aws); non-blocking degraded-hierarchy notice.Testing (integration-first)
/organizational-unitsroutes; suite stays green underonUnhandledRequest: "error", proving the UI is fully canonical.Notes
no-changelog(the feature's changelog fragment lands once on the principal branch)./organization-nodes).Spec:
openspec/changes/gcp-organization-onboarding-ui(tasks 2.1–2.11).