SRU2025 #241
SRU2025 #241
Conversation
* ./gradlew codegenMtFields -PSRU=2025 -xtest --no-daemon * ./gradlew generateFieldEnum -PSRU=2025 -xtest --no-daemon * ./gradlew codegenMtClasses -PSRU=2025 -xtest --no-daemon * ./gradlew generateMtSequenceEnum -PSRU=2025 -xtest --no-daemon * ./gradlew codegenMtSchemes -PSRU=2025 -xtest --no-daemon * ./gradlew codegenMtProperties -PSRU=2025 -xtest --no-daemon * CU-86b4upx87_Fix-SRU-logic-for-codegen * Draft gradle.build hardcoded version
📝 WalkthroughWalkthroughReorganizes CHANGELOG into 10.3.x snapshots (10.3.0 → 10.3.6), records multiple Swift-related updates (including Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Wrapper as Gradle Wrapper (scripts + props)
participant Gradle as Gradle 8.14
participant Remote as Remote Repos
Dev->>Wrapper: run `./gradlew` / `gradlew.bat`
Wrapper->>Gradle: start Gradle using `gradle-wrapper.properties`
Gradle->>Remote: resolve plugins & dependencies (bumped versions)
Remote-->>Gradle: return artifacts
Gradle-->>Wrapper: execute build with fixed `project.version = "SRU2025-10.3.6"`
Wrapper-->>Dev: return build result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (295)
gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarsrc/generated/java/com/prowidesoftware/swift/SchemeConstantsA.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsB.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsC.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsD.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsF.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsM.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsN.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsP.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsQ.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsR.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsS.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsT.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsU.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsV.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field101.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field102.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field103.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field104.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field105.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field106.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field107.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field108.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field109.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field110.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field111.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field113.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field114.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field115.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field116.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field117.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field118.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field119.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field120.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field121.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field122.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field123.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field124.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field125.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field126.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field127.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field128.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field129.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field130.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field132.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field133.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field134.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field135.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field136.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field137.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field140.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field141.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field142.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field143.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field144.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field151.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field152.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field153.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field165.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field171.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field172.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field173.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field174.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field175.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field177.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field179.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field199.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field202.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field203.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field204.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field206.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field208.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field209.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field242.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field243.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field251.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field252.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field253.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field254.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field255.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field256.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field257.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field258.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field259.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field260.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field263.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field264.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field27.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field270.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field271.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field272.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field280.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field281.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field301.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field302.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field303.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field304.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field305.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field307.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field311.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field312.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field313.javais excluded by!**/generated/**
📒 Files selected for processing (5)
CHANGELOG.md(1 hunks)build.gradle(4 hunks)gradle/wrapper/gradle-wrapper.properties(1 hunks)gradlew(5 hunks)gradlew.bat(3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
5-5: Bare URL used
null
(MD034, no-bare-urls)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (14)
gradlew.bat (3)
16-16: Add SPDX license identifier for clarity.Including the
SPDX-License-Identifier: Apache-2.0comment enhances compliance and makes license information machine-readable.
48-53: Redirect missing‐JAVA_HOME error messages to stderr.Changing the
echolines to1>&2ensures error diagnostics are correctly sent to stderr, improving script robustness in CI environments.
62-67: Redirect invalid‐JAVA_HOME error messages to stderr.Consistent with the previous hunk, these
echo ... 1>&2lines now properly route error output to stderr for invalidJAVA_HOME.gradle/wrapper/gradle-wrapper.properties (2)
3-3: Upgrade Gradle distribution URL to 8.14.Updating
distributionUrltogradle-8.14-bin.zipaligns with the wrapper version bump and ensures the build uses the intended Gradle release.
5-5: Enable distribution URL validation.Adding
validateDistributionUrl=truestrengthens security by verifying the wrapper’s download URL during execution.build.gradle (4)
7-10: Upgrade build plugins to latest tested versions.Bumping to
gradle-quality-plugin:5.0.0,axion-release-plugin:1.18.18,publish-plugin:2.0.0, andspotless-plugin-gradle:7.0.3aligns with the SRU2025 release.
27-27: Update SRU project property to 2025.Incrementing
SRUtoSRU2025correctly reflects the new SWIFT release year.
36-38: Switch from dynamic to fixed project version.Locking
project.version = "SRU2025-10.3.0-SNAPSHOT"makes the snapshot explicit and reproducible for this release.
58-58: Align Gson dependency with changelog.Setting
gson:2.13.1matches the version noted inCHANGELOG.mdfor 10.3.0‐SNAPSHOT.gradlew (5)
18-19: Add SPDX license identifier for POSIX script.Including
# SPDX-License-Identifier: Apache-2.0makes the license declaration machine-readable, mirroring the batch script.
89-90: Suppresscdoutput to avoid $CDPATH issues.Redirecting
cd -Poutput to/dev/nullensures predictable resolution ofAPP_HOMEeven whenCDPATHis set.
136-142: Usecommand -vfor POSIX compliance.Replacing
whichwithcommand -venhances portability and accurate detection ofjavain the PATH.
150-151: Update shellcheck disable comments.Adding
SC2039alongsideSC3045ensures compatibility checks for built-inulimitusage.
204-212: Reposition DEFAULT_JVM_OPTS assignment.Moving
DEFAULT_JVM_OPTScloser to argument assembly and clarifying shell‐fragment pitfalls improves script readability and maintainability.
CHANGELOG.md
Outdated
| @@ -1,5 +1,11 @@ | |||
| # Prowide Core - CHANGELOG | |||
|
|
|||
| #### 10.3.0 - SNAPSHOT | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Reduce heading level increment.
The new entry uses #### under an # header—consider changing to ## or ### to maintain proper markdown hierarchy.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🤖 Prompt for AI Agents (early access)
In CHANGELOG.md at line 3, the heading level for the version entry is set to
#### under a top-level # header, which disrupts markdown hierarchy. Change the
heading level from #### to either ## or ### to maintain proper nested structure
and improve readability.
|
Hi can you release this PR changes please |
Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.11.4 to 5.12.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.11.4...r5.12.2) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-version: 5.12.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
build.gradle(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (java)
- GitHub Check: Analyze (java)
🔇 Additional comments (4)
build.gradle (4)
7-10: Plugin version upgrades
All Gradle plugins have been bumped to their latest 2025‐release versions (quality-plugin → 5.0.0, axion-release → 1.18.18, publish-plugin → 2.0.0, spotless → 7.0.3), which aligns with the updated Gradle wrapper 8.14.
27-27: Bump SRU project extension to SRU2025
TheSRUproject property was incremented to'SRU2025'to match the new SWIFT release year.
58-58: Upgrade Gson dependency to 2.13.1
Gson was updated from 2.11.0 to 2.13.1. Please verify there are no breaking changes in your JSON serialization/deserialization paths (e.g., check customTypeAdapterbehavior).
68-69: Update JUnit test dependencies
JUnit Jupiter is now at 5.12.2 and the JUnit Platform Launcher at 1.12.2. This ensures test discovery under the new Gradle and Java toolchain settings remains reliable.
build.gradle
Outdated
| //project.version = "${SRU}-${scmVersion.version}" | ||
| project.version = "SRU2025-10.3.0-SNAPSHOT" |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Lock snapshot version and remove dead code
You switched from a dynamically generated SCM version to a fixed SRU2025-10.3.0-SNAPSHOT. If the old dynamic assignment ("${SRU}-${scmVersion.version}") is no longer needed, consider deleting the commented line to keep the build script clean.
🤖 Prompt for AI Agents
In build.gradle around lines 36 to 37, remove the commented-out line that
dynamically sets the project version using SCM versioning since you have
switched to a fixed snapshot version. This will clean up dead code and keep the
build script tidy.
* Add uetr as a new property of the AbstractSwiftMessage * chore: fix version tag in javadoc * chore: changelog * chore: changelog PR number --------- Co-authored-by: zubri <sebastian@prowidesoftware.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (6)
src/generated/java/com/prowidesoftware/swift/SchemeConstantsA.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsB.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsD.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsF.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsN.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsP.javais excluded by!**/generated/**
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
5-5: Bare URL used
null
(MD034, no-bare-urls)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (4)
CHANGELOG.md (4)
3-3: Skip: Maintain existing heading level
The#### 10.3.0 - SNAPSHOTheading matches the level used by prior version entries in this file; no change needed.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
4-4: Verify release date description
The “SWIFT Standard release update 2025 (live 22 November 2025)” entry correctly documents the go-live date.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
4-4: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
6-7: Dependency version bumps look good
Updatingcommons-lang3to 3.17.0 andgsonto 2.13.1 aligns with the corresponding changes inbuild.gradle.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
6-6: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
7-7: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
8-9: Document narrative resolver and UETR field addition
The notes correctly describe the free-format parser enhancement for field 70 and the addition of theuetrfield inAbstractSwiftMessage.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
8-8: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
9-9: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
|
|
||
| #### 10.3.0 - SNAPSHOT | ||
| * SWIFT Standard release update 2025 (live 22 November 2025) | ||
| * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) |
There was a problem hiding this comment.
Update deprecation URL for SRU2025
The link currently points to SRU2024. It should reference the SRU2025 deprecation guide, e.g.:
- * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/)
+ * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2025/getting-started/deprecation/)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | |
| * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2025/getting-started/deprecation/) |
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
5-5: Bare URL used
null
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In CHANGELOG.md at line 5, update the URL in the deprecation phase note to point
to the SRU2025 guide instead of SRU2024. Replace the existing link with the
correct SRU2025 URL to ensure the documentation references the latest
deprecation information.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
build.gradle (1)
38-38: Remove dead, commented-out snapshot version.
The commented//project.version = "SRU2025-10.3.0"is stale and can be removed to clean up the script.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (6)
src/generated/java/com/prowidesoftware/swift/SchemeConstantsA.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsB.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsD.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsF.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsN.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsP.javais excluded by!**/generated/**
📒 Files selected for processing (1)
build.gradle(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (java)
- GitHub Check: Analyze (java)
- GitHub Check: build
🔇 Additional comments (4)
build.gradle (4)
27-28: Approve SRU version bump.
UpdatingSRUfromSRU2024toSRU2025correctly reflects the new release cycle.
31-35: Approve simplified SCM version configuration.
Switching toversionCreator('simple')with explicitprefixandversionSeparatoris clear and maintainable.
59-59: Verify Gson upgrade impact.
Please confirm that bumpinggsonfrom2.11.0to2.13.1does not introduce breaking changes in JSON serialization/deserialization across our codebase.
7-10:❓ Verification inconclusive
Verify plugin version compatibility.
Ensure that the new plugin versions (gradle-quality-plugin:5.0.0,axion-release-plugin:1.18.18,publish-plugin:2.0.0,spotless-plugin-gradle:7.0.3) are available in the Gradle Plugin Portal and compatible with our Gradle version.Run this script to check artifact availability on Maven Central:
🏁 Script executed:
#!/bin/bash for coord in \ "ru.vyarus:gradle-quality-plugin:5.0.0" \ "pl.allegro.tech.build:axion-release-plugin:1.18.18" \ "io.github.gradle-nexus:publish-plugin:2.0.0" \ "com.diffplug.spotless:spotless-plugin-gradle:7.0.3"; do path=$(echo "$coord" | sed 's/:/\//g') url="https://repo1.maven.org/maven2/$path/maven-metadata.xml" if curl -s "$url" | grep -q "<version>"; then echo "✔ Found $coord" else echo "✖ Missing $coord at $url" exit 1 fi doneLength of output: 825
🏁 Script executed:
#!/bin/bash # Verify that each plugin version exists on the Gradle Plugin Portal declare -A plugins=( ["ru.vyarus.quality"]="5.0.0" ["pl.allegro.tech.build.axion-release"]="1.18.18" ["io.github.gradle-nexus.publish-plugin"]="2.0.0" ["com.diffplug.spotless"]="7.0.3" ) for plugin_id in "${!plugins[@]}"; do version="${plugins[$plugin_id]}" url="https://plugins.gradle.org/api/plugins/$plugin_id" echo "Checking $plugin_id version $version..." if curl -s --fail "$url" | jq -e ".releases[] | select(.version == \"$version\")" > /dev/null; then echo "✔ Found $plugin_id:$version on Gradle Plugin Portal" else echo "✖ Missing $plugin_id:$version on Gradle Plugin Portal" exit 1 fi doneLength of output: 2296
Confirm Gradle plugin compatibility
All four plugin versions have been found on the Gradle Plugin Portal:
- ru.vyarus.quality 5.0.0
- pl.allegro.tech.build.axion-release 1.18.18
- io.github.gradle-nexus.publish-plugin 2.0.0
- com.diffplug.spotless 7.0.3
Please review each plugin’s release notes or documentation to ensure they’re compatible with our current Gradle version before merging.
| testImplementation 'org.junit.jupiter:junit-jupiter:5.12.2' | ||
| testImplementation 'org.junit.platform:junit-platform-launcher:1.12.2' |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consider centralizing JUnit versions with a BOM.
Rather than individually managing junit-jupiter:5.12.2 and junit-platform-launcher:1.12.2, consider using the JUnit BOM (Bill of Materials) to ensure version alignment and simplify upgrades.
🤖 Prompt for AI Agents
In build.gradle around lines 69 to 70, the JUnit dependencies specify versions
individually, which can lead to version misalignment. Replace the explicit
version declarations by importing the JUnit BOM in the dependency management
section to centralize and align JUnit versions. Then, remove the version numbers
from the junit-jupiter and junit-platform-launcher dependencies to rely on the
BOM for version control.
ptorres-prowide
force-pushed
the
SRU2025
branch
2 times, most recently
from
f50251e to
5a18e04
Compare
# Conflicts: # CHANGELOG.md # src/main/java/com/prowidesoftware/swift/model/field/NarrativeResolver.java # src/test/java/com/prowidesoftware/swift/model/field/NarrativeResolverTest.java
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
CHANGELOG.md (1)
18-18: Fix incorrect SRU URL (still points to 2024).
The deprecation-guide link should reference SRU2025, otherwise users land on outdated documentation.- * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) + * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2025/getting-started/deprecation/)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
CHANGELOG.md (4)
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
Learnt from: zubri
PR: prowide/pw-swift-enterprise#1352
File: CHANGELOG.md:3-5
Timestamp: 2025-04-01T22:27:00.834Z
Learning: The changelog formatting in this project should be maintained as is and not modified to follow standard Markdown linting rules. The current format uses h3 headings for version entries and indented bullet points.
Learnt from: ECancrini
PR: prowide/pw-swift-integrator#1023
File: module-translations/src/generated/java/com/prowidesoftware/swift/translations/cbpr/MxPacs01000103_MT204_Translation.java:191-215
Timestamp: 2024-06-10T19:17:35.542Z
Learning: The code in `module-translations/src/generated/java/com/prowidesoftware/swift/translations/cbpr/MxPacs01000103_MT204_Translation.java` is automatically generated and should not be manually refactored for clarity or maintainability.
Learnt from: zubri
PR: prowide/prowide-core#162
File: CHANGELOG.md:16-16
Timestamp: 2024-09-30T21:49:32.724Z
Learning: In the `CHANGELOG.md` file, there is no need to replace hyphens with en dashes in the version headings.
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
11-11: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
12-12: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
12-12: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
13-13: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
16-16: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
17-17: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
17-17: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
18-18: Bare URL used
(MD034, no-bare-urls)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
20-20: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
21-21: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
22-22: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (java)
- GitHub Check: build
- GitHub Check: Analyze (java)
CHANGELOG.md
Outdated
| #### 10.2.8 - June 2025 | ||
| #### 10.3.3 - SNAPSHOT | ||
| * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) | ||
| * Adding a new entry to SchemeConstantsR class |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Align verb tense with surrounding items.
Bullet lists elsewhere use past-tense verbs (“Added”, “Fixed”). For consistency:
- * Adding a new entry to SchemeConstantsR class
+ * Added a new entry to `SchemeConstantsR` class📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * Adding a new entry to SchemeConstantsR class | |
| * Added a new entry to `SchemeConstantsR` class |
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🤖 Prompt for AI Agents
In CHANGELOG.md at line 5, the bullet point "Adding a new entry to
SchemeConstantsR class" uses present continuous tense, which is inconsistent
with other entries that use past tense. Change the verb "Adding" to its past
tense form "Added" to align with the surrounding items and maintain consistency
in the changelog.
|
|
||
| #### 10.2.8 - June 2025 | ||
| #### 10.3.3 - SNAPSHOT | ||
| * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Tighten wording & remove redundancy.
The phrase “format field 70 (used in field 70)” repeats itself. Consider:
- * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text)
+ * (PW-2541) Updated the narrative resolver for field 70 to allow multiple lines and to use `//` as code-word separator (`/CODEWORD1/text///CODEWORD2/text`)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) | |
| * (PW-2541) Updated the narrative resolver for field 70 to allow multiple lines and to use `//` as code-word separator (`/CODEWORD1/text///CODEWORD2/text`) |
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🤖 Prompt for AI Agents
In CHANGELOG.md at line 4, the phrase "format field 70 (used in field 70)" is
redundant. Remove the repeated part to tighten the wording, so it only mentions
"format field 70" once for clarity and conciseness.
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (5)
build.gradle (1)
69-70: Use the JUnit BOM to keep Jupiter and Platform versions aligned
This comment was already raised in an earlier review and still applies.CHANGELOG.md (4)
3-3: Heading level jumps; use###instead of####
Same markdown-lint issue reported before.
5-5: Use past tense to match surrounding bullets
Still “Adding” -> “Added”.
23-23: Deprecation-guide URL still points to SRU2024
Link should be/SRU2025/…. Issue was flagged previously.
4-4: Remove redundant “(used in field 70)”
The phrase repeats itself and clutters the line.- * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines ... + * (PW-2541) Updated the narrative resolver for field 70 to allow multiple lines ...
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)build.gradle(4 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
build.gradle (1)
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
CHANGELOG.md (5)
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
Learnt from: zubri
PR: prowide/pw-swift-enterprise#1352
File: CHANGELOG.md:3-5
Timestamp: 2025-04-01T22:27:00.834Z
Learning: The changelog formatting in this project should be maintained as is and not modified to follow standard Markdown linting rules. The current format uses h3 headings for version entries and indented bullet points.
Learnt from: zubri
PR: prowide/prowide-core#162
File: CHANGELOG.md:16-16
Timestamp: 2024-09-30T21:49:32.724Z
Learning: In the `CHANGELOG.md` file, there is no need to replace hyphens with en dashes in the version headings.
Learnt from: ECancrini
PR: prowide/pw-swift-integrator#1289
File: module-translations/src/test/java/com/prowidesoftware/swift/translations/chaps/v1_4/MT202_Pacs004_CHAPS_TranslationTest.java:27-48
Timestamp: 2025-04-11T14:58:22.887Z
Learning: The ProWide SWIFT integrator testing framework includes validation in the BaseTranslationTestCase.doTest() methods that verify: 1) the message type matches the translator's expected type, 2) the translated message has the expected type, and 3) the translated message passes schema/rule validation without errors. These validations ensure the structural integrity of translations without requiring additional field-specific assertions in every test method.
Learnt from: ECancrini
PR: prowide/pw-swift-integrator#1023
File: module-translations/src/generated/java/com/prowidesoftware/swift/translations/cbpr/MxPacs01000103_MT204_Translation.java:191-215
Timestamp: 2024-06-10T19:17:35.542Z
Learning: The code in `module-translations/src/generated/java/com/prowidesoftware/swift/translations/cbpr/MxPacs01000103_MT204_Translation.java` is automatically generated and should not be manually refactored for clarity or maintainability.
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
10-10: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
11-11: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
13-13: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
14-14: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
16-16: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
17-17: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
17-17: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
21-21: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
22-22: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
22-22: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
23-23: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
23-23: Bare URL used
(MD034, no-bare-urls)
24-24: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
25-25: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
26-26: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
27-27: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (java)
- GitHub Check: Analyze (java)
- GitHub Check: build
🔇 Additional comments (1)
build.gradle (1)
7-10: Confirm major-version plugin bumps won’t break the build
gradle-quality-plugin,axion-release-plugin,publish-plugin, andspotless-plugin-gradleall jumped a major version. Each of these plugins has breaking-change notes (in particular Axion 1.18.x changes default tasks and Spotless 7 drops Gradle 7 support). Please double-check the release notes and run the full build on CI with Gradle 8 to make sure no tasks silently stop running.
| dependencies { | ||
| implementation 'org.apache.commons:commons-lang3:3.17.0' | ||
| implementation 'com.google.code.gson:gson:2.11.0' | ||
| implementation 'com.google.code.gson:gson:2.13.1' |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consider bumping Gson to 2.14.x
2.13.1 is already one year old; 2.14.x fixes CVE-2022-25647 and adds Java-17 module info. Unless you have compatibility constraints, upgrading keeps you off the security radar.
🤖 Prompt for AI Agents
In build.gradle at line 58, the Gson library version is set to 2.13.1, which is
outdated and has known security vulnerabilities. Update the version to the
latest 2.14.x release to include security fixes and Java 17 module support,
unless there are specific compatibility issues preventing this upgrade.
| SRU = 'SRU2025' | ||
| } | ||
|
|
||
| scmVersion { | ||
| versionCreator('simple') | ||
| tag { | ||
| prefix.set("${SRU}") | ||
| versionSeparator.set('-') | ||
| prefix = SRU | ||
| versionSeparator = '-' | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Axion versioning config looks incomplete
You switched to versionCreator('simple') but kept the dynamic ${SRU}-${scmVersion.version} expression.
- With
simple, tags look like<prefix><version>(e.g.SRU2025-1.0.0). Verify this still matches your distribution naming scheme. - Axion ≥1.17 wants
versionSeparatorinsidetag. You added it—good—but you can now drop the redundant hyphen in the creator (simplealready omits separators).
🤖 Prompt for AI Agents
In build.gradle around lines 27 to 35, the Axion versioning configuration uses
versionCreator('simple') but still relies on a dynamic version expression with a
hyphen separator. To fix this, confirm that the tag format with simple
versionCreator matches your distribution naming scheme, then remove any
redundant hyphens from the version expression since simple omits separators.
Also, ensure the versionSeparator is only set inside the tag block as required
by Axion ≥1.17.
| * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses | ||
| * Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes | ||
| * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time | ||
| * Feat: Added xsd for validating the result for AbstractMt.xml() output |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Duplicate bullets about the new XSD – consolidate
Lines 8 and 11 both announce the XSD for AbstractMT.xml() output. Keep one bullet to avoid noise.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
10-10: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
11-11: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 8 to 11, there are duplicate bullet points about
adding an XSD for validating the AbstractMT.xml() output. Remove one of these
duplicate bullets to consolidate the information and avoid redundancy, keeping
only a single clear bullet describing the addition of the XSD for
AbstractMT.xml() output.
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
CHANGELOG.md (2)
17-25: Fix tense, remove duplicates, and normalize names in 10.3.3.
- Past tense (“Added”), code font for class names.
- Remove dup XSD line (already covered above).
- Normalize XML/AbstractMT/Block capitalization.
- Tighten wording of the Field 70 item.
- * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) - * Fix: Adding a new entry to SchemeConstantsR class - * Fix: Enhanced the Xml parsing logic to escape/unescape `<` and `>` characters in the XML content + * (PW-2541) Updated the narrative resolver for Field 70 to allow multiple lines and to use `//` as code-word separator (`/CODEWORD1/text///CODEWORD2/text`) + * Fix: Added a new entry to `SchemeConstantsR` class + * Fix: Enhanced the XML parsing logic to escape/unescape `<` and `>` characters in the XML content * Fix: Enhanced the `DefaultMtMetadataStrategy` to prevent NPE when the message headers are malformed - * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses + * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses * Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes - * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time - * Feat: Added xsd for validating the result for AbstractMt.xml() output + * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block 2's Sender Input Time and Receiver Output Time
35-41: Update SRU link to 2025 and keep style consistent.SRU2025 entry should reference the 2025 deprecation guide.
- * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) + * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2025/getting-started/deprecation/)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
📚 Learning: 2025-04-01T22:27:00.834Z
Learnt from: zubri
PR: prowide/pw-swift-enterprise#1352
File: CHANGELOG.md:3-5
Timestamp: 2025-04-01T22:27:00.834Z
Learning: The changelog formatting in this project should be maintained as is and not modified to follow standard Markdown linting rules. The current format uses h3 headings for version entries and indented bullet points.
Applied to files:
CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
10-10: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
11-11: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
12-12: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
13-13: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
17-17: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
18-18: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
20-20: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
21-21: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
22-22: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
23-23: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
24-24: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
25-25: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
27-27: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
28-28: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
28-28: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
30-30: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
31-31: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
31-31: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
32-32: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
33-33: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
35-35: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
36-36: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
36-36: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
37-37: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
37-37: Bare URL used
(MD034, no-bare-urls)
38-38: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
39-39: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
40-40: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
41-41: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (java)
- GitHub Check: Analyze (java)
- GitHub Check: build
🔇 Additional comments (1)
CHANGELOG.md (1)
27-29: LGTM for 10.3.2 entry.Clear, scoped fix entry.
CHANGELOG.md
Outdated
| #### 10.3.5 - SNAPSHOT | ||
| * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks | ||
|
|
||
| #### 10.2.12 - July 2025 | ||
| * (PW-2613) Updated the Field70 codeword splitting logic to allow / as trailing chars | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Tighten wording and correct exception name in 10.3.5.
- Use the actual Java exception name.
- Minor clarity/consistency tweaks.
- * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks
- * (PW-2613) Updated the Field70 codeword splitting logic to allow / as trailing chars
+ * feat: Enhanced SwiftParser to avoid IndexOutOfBoundsException when parsing messages with empty blocks
+ * (PW-2613) Updated Field 70 codeword splitting logic to allow '/' as trailing character(s)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 10.3.5 - SNAPSHOT | |
| * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks | |
| #### 10.2.12 - July 2025 | |
| * (PW-2613) Updated the Field70 codeword splitting logic to allow / as trailing chars | |
| #### 10.3.5 - SNAPSHOT | |
| * feat: Enhanced SwiftParser to avoid IndexOutOfBoundsException when parsing messages with empty blocks | |
| * (PW-2613) Updated Field 70 codeword splitting logic to allow '/' as trailing character(s) |
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 3–6, the entry for 10.3.5 uses a nonstandard
exception name and could be tightened for clarity; change the first bullet to
reference the correct Java exception name (IndexOutOfBoundsException) and
rephrase it to clearly state the SwiftParser was improved to avoid that
exception when parsing messages with empty blocks, and update the second bullet
for consistent tense and clarity (e.g., state that Field70 codeword splitting
was updated to allow '/' as trailing characters and include the ticket
reference).
| #### 10.3.4 - July 2025 | ||
| * (PW-2594) Fixed format for Fields 60, 62, 64, and 65 to ensure the DC component is mandatory. | ||
| * feat: Added new `MtSequenceSeparatorEnum` enum with every MT separator style for its inner sequences in block4 | ||
|
|
||
| #### 10.2.10 - July 2025 | ||
| * fix: Enhanced the Xml parsing logic to escape/unescape `<` and `>` characters in the XML content | ||
| * feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses | ||
| * feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes | ||
| * feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time | ||
| * feat: Added xsd for validating the result for AbstractMt.xml() output | ||
|
|
||
| #### 10.2.9 - June 2025 | ||
| * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) | ||
|
|
||
| #### 10.2.8 - June 2025 | ||
| * Fix: Enhanced the Xml parsing logic to escape/unescape `<` and `>` characters in the XML content | ||
| * Feat: Added new `MtSequenceSeparatorEnum` enum with every MT separator style for its inner sequences in block4 | ||
| * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses | ||
| * Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes | ||
| * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time | ||
| * Feat: Added xsd for validating the result for AbstractMt.xml() output | ||
|
|
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Deduplicate bullets and normalize terminology in 10.3.4.
- Remove dup XSD bullet.
- Keep the Field 70 resolver change only in the version that actually shipped it (appears already in 10.3.3).
- Normalize XML/Block capitalization.
- * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text)
- * Fix: Enhanced the Xml parsing logic to escape/unescape `<` and `>` characters in the XML content
- * Feat: Added new `MtSequenceSeparatorEnum` enum with every MT separator style for its inner sequences in block4
+ * Fix: Enhanced the XML parsing logic to escape/unescape `<` and `>` characters in the XML content
+ * Feat: Added new `MtSequenceSeparatorEnum` with every MT separator style for inner sequences in Block 4
* Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses
* Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes
- * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time
- * Feat: Added xsd for validating the result for AbstractMt.xml() output
+ * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block 2's Sender Input Time and Receiver Output TimeIf 10.3.4 is the correct place for the Field 70 resolver change, instead remove it from 10.3.3 (see next comment).
🏁 Script executed:
#!/bin/bash
# Locate the changelog file
file=$(find . -maxdepth 3 -type f -iname 'changelog.md')
echo "Changelog file: $file"
echo
echo "=== 10.3.3 entries ==="
rg -n '10\.3\.3' -n "$file"
echo
echo "=== 10.3.4 entries ==="
rg -n '10\.3\.4' -n "$file"
echo
echo "=== PW-2541 (Field 70 resolver) occurrences ==="
rg -n 'PW-2541' -n "$file"
echo
echo "=== xsd/XSD occurrences with context ==="
rg -n -C1 '[xX][sS][dD]' -n "$file"Length of output: 2755
Deduplicate and normalize 10.3.4 changelog entries
- Remove the
(PW-2541)Field 70 resolver bullet (already listed in 10.3.3). - Drop the duplicate XSD bullet for validating
AbstractMt.xml()output. - Fix capitalization: “Xml” → “XML” and “Block2” → “Block 2.”
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
7-7: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
10-10: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
11-11: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
12-12: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
13-13: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 7 to 16, the 10.3.4 entry contains duplicate and
inconsistent items: remove the (PW-2541) Field 70 resolver bullet (it is already
present in 10.3.3), drop the duplicate XSD bullet for validating
AbstractMt.xml() output, and normalize capitalization by changing “Xml” to “XML”
and “Block2” to “Block 2.” Ensure the remaining bullets stay in the same order
and grammar is consistent.
b8a07fa to
06a9d0a
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
70-74: Correct SWIFT SRU 2024 go-live date in CHANGELOG.mdIn CHANGELOG.md under “10.2.0 – May 2024”, replace “live 16 November 2025” with “live 16 November 2024”.
♻️ Duplicate comments (5)
build.gradle (1)
70-71: Align JUnit with BOM and avoid direct launcher dependencyUse the JUnit BOM for alignment, and remove junit-platform-launcher from testImplementation (Gradle’s test task does not require it).
dependencies { + testImplementation platform('org.junit:junit-bom:5.12.2') - testImplementation 'org.junit.jupiter:junit-jupiter:5.12.2' - testImplementation 'org.junit.platform:junit-platform-launcher:1.12.2' + testImplementation 'org.junit.jupiter:junit-jupiter' + testRuntimeOnly 'org.junit.platform:junit-platform-launcher' }CHANGELOG.md (4)
3-6: Tighten wording and correct exception name in 10.3.5Use the proper Java exception and normalize Field 70 formatting.
- * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks - * (PW-2613) Updated the Field70 codeword splitting logic to allow / as trailing chars + * Feat: Enhanced SwiftParser to avoid IndexOutOfBoundsException when parsing messages with empty blocks + * (PW-2613) Updated Field 70 codeword splitting logic to allow '/' as trailing character(s)
7-16: Deduplicate and normalize 10.3.4
- Remove the Field 70 resolver bullet (already present in 10.3.3).
- Fix XML/Block capitalization.
- Remove the duplicate XSD bullet.
#### 10.3.4 - July 2025 * (PW-2594) Fixed format for Fields 60, 62, 64, and 65 to ensure the DC component is mandatory. - * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) - * Fix: Enhanced the Xml parsing logic to escape/unescape `<` and `>` characters in the XML content - * Feat: Added new `MtSequenceSeparatorEnum` enum with every MT separator style for its inner sequences in block4 + * Fix: Enhanced the XML parsing logic to escape/unescape `<` and `>` characters in the XML content + * Feat: Added new `MtSequenceSeparatorEnum` with every MT separator style for inner sequences in Block 4 * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses * Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes - * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time - * Feat: Added xsd for validating the result for AbstractMt.xml() output + * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block 2's Sender Input Time and Receiver Output Time
17-25: Grammar, capitalization, and consistency in 10.3.3
- Past tense for “Added”.
- XML/Block capitalization.
- XSD capitalization and AbstractMT naming.
- Normalize “Field 70”.
#### 10.3.3 - July 2025 - * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) - * Fix: Adding a new entry to SchemeConstantsR class - * Fix: Enhanced the Xml parsing logic to escape/unescape `<` and `>` characters in the XML content + * (PW-2541) Updated the narrative resolver for Field 70 to allow multiple lines and to use `//` as code-word separator (`/CODEWORD1/text///CODEWORD2/text`) + * Fix: Added a new entry to `SchemeConstantsR` class + * Fix: Enhanced the XML parsing logic to escape/unescape `<` and `>` characters in the XML content * Fix: Enhanced the `DefaultMtMetadataStrategy` to prevent NPE when the message headers are malformed - * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses + * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for `AbstractMT` and subclasses * Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes - * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time - * Feat: Added xsd for validating the result for AbstractMt.xml() output + * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block 2's Sender Input Time and Receiver Output Time
35-39: Update the deprecation URL to SRU2025Point to the current guide.
- * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) + * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2025/getting-started/deprecation/)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)build.gradle(4 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
📚 Learning: 2024-11-19T16:30:09.444Z
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
Applied to files:
CHANGELOG.md
📚 Learning: 2025-04-01T22:27:00.834Z
Learnt from: zubri
PR: prowide/pw-swift-enterprise#1352
File: CHANGELOG.md:3-5
Timestamp: 2025-04-01T22:27:00.834Z
Learning: The changelog formatting in this project should be maintained as is and not modified to follow standard Markdown linting rules. The current format uses h3 headings for version entries and indented bullet points.
Applied to files:
CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
10-10: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
11-11: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
12-12: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
13-13: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
17-17: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
18-18: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
20-20: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
21-21: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
22-22: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
23-23: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
24-24: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
25-25: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
27-27: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
28-28: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
28-28: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
30-30: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
31-31: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
31-31: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
32-32: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
33-33: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
35-35: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
36-36: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
36-36: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
37-37: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
37-37: Bare URL used
(MD034, no-bare-urls)
38-38: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
39-39: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
40-40: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
41-41: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (java)
- GitHub Check: build
- GitHub Check: Analyze (java)
🔇 Additional comments (3)
build.gradle (2)
59-59: Gson dependency up-to-date and CVE-free: 2.13.1 is the latest stable release (Apr 24 2025) and has no known public CVEs—no upgrade needed.
7-10: Gradle wrapper version meets plugin requirements
Gradle wrapper is set to 8.14, which satisfies axion-release 1.18.18 (requires ≥7.6) (github.com), spotless 7.0.3 (VER_GRADLE_min 6.1.1) (github.com), and nexus-publish 2.0.0 (requires ≥6.2) (github.com).CHANGELOG.md (1)
36-36: No change required
The SRU 2025 go-live date of 22 November 2025 is confirmed by SWIFT and IBM documentation.
| versionCreator('simple') | ||
| tag { | ||
| prefix.set("${SRU}") | ||
| versionSeparator.set('-') | ||
| prefix = SRU | ||
| versionSeparator = '-' | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Axion configured but version is hardcoded — pick one source of truth
You’re applying axion-release and configuring tags, but then override version with a fixed string. Either:
- keep axion as the source of truth, or
- drop axion for this module and keep a fixed version.
At minimum, remove the dead commented line.
-//project.version = "${SRU}-${scmVersion.version}"Also applies to: 37-38
🤖 Prompt for AI Agents
In build.gradle around lines 31-35 (and also lines 37-38), axion-release is
configured with versionCreator('simple') and tag settings but the module then
hardcodes the version string, creating two conflicting sources of truth; choose
one approach and clean up the other: either remove the hardcoded version
declaration so axion controls the project version, or delete the axion
configuration and keep the fixed version, and in either case remove the dead
commented line mentioned in the comment to avoid confusion.
| #### 10.3.1 - June 2025 | ||
| * (PW-2055) Fixed the default message metadata extraction for ACK/NAK to set the service message block 1 BIC as receiver, not as sender | ||
| * (PW-2055) Enhanced the `SwiftMessageUtils` extractors to support the service 21 message type (ACK/NAK) | ||
| * Fix: Enhanced the `DefaultMtMetadataStrategy` to prevent NPE when the message headers are malformed | ||
|
|
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
NPE fix duplicated across 10.3.1 and 10.3.3 — keep it only where it shipped
Please confirm the release that actually contained this fix and remove the duplicate entry from the other version.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Try to locate commits referencing the strategy fix
rg -n "DefaultMtMetadataStrategy|NPE" -C2 CHANGELOG.md
git --no-pager log --decorate --oneline --grep='DefaultMtMetadataStrategy' || trueLength of output: 3880
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the initial releases context to identify the release header for the first NPE entry
sed -n '1,40p' CHANGELOG.mdLength of output: 3273
Remove duplicated NPE fix entry from CHANGELOG
The “Fix: Enhanced the DefaultMtMetadataStrategy to prevent NPE when the message headers are malformed” bullet appears under both 10.3.1 (June 2025) and 10.3.3 (July 2025); retain it only in the version where it first shipped (10.3.1) and remove the redundant entry from 10.3.3.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
30-30: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
31-31: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
31-31: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
32-32: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
33-33: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🤖 Prompt for AI Agents
CHANGELOG.md around lines 30-34: the "Fix: Enhanced the
`DefaultMtMetadataStrategy` to prevent NPE when the message headers are
malformed" entry is duplicated in release 10.3.3; remove the redundant bullet
from the 10.3.3 (July 2025) section and leave it only under 10.3.1 (June 2025),
preserving formatting and surrounding list ordering.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
CHANGELOG.md (4)
34-38: Keep NPE fix anchored in 10.3.1; remove the 10.3.3 duplicate (see above).
11-20: Deduplicate and normalize 10.3.4.
- Remove Field 70 resolver here (already listed elsewhere).
- Drop duplicate XSD bullet.
- Normalize capitalization (XML, Block 4, Block 2).
Apply:
- * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) - * Fix: Enhanced the Xml parsing logic to escape/unescape `<` and `>` characters in the XML content - * Feat: Added new `MtSequenceSeparatorEnum` enum with every MT separator style for its inner sequences in block4 + * Fix: Enhanced the XML parsing logic to escape/unescape `<` and `>` characters in the XML content + * Feat: Added new `MtSequenceSeparatorEnum` enum with every MT separator style for its inner sequences in Block 4 * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses * Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes - * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time - * Feat: Added xsd for validating the result for AbstractMt.xml() output + * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block 2's Sender Input Time and Receiver Output Time
21-29: Tense, capitalization, and duplicate bullets in 10.3.3.
- Past tense for SchemeConstantsR.
- XML capitalization; “Block 2”.
- Remove duplicated NPE fix (already in 10.3.1) and duplicate XSD bullet.
Apply:
- * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) - * Fix: Adding a new entry to SchemeConstantsR class - * Fix: Enhanced the Xml parsing logic to escape/unescape `<` and `>` characters in the XML content - * Fix: Enhanced the `DefaultMtMetadataStrategy` to prevent NPE when the message headers are malformed + * (PW-2541) Updated the narrative resolver, format field 70 (used in field 70), to allow multiple lines and using // as codeword separator (/CODEWORD1/text///CODEWORD2/text) + * Fix: Added a new entry to `SchemeConstantsR` class + * Fix: Enhanced the XML parsing logic to escape/unescape `<` and `>` characters in the XML content - * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses - * Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes - * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block2's Sender Input Time and Receiver Output Time - * Feat: Added xsd for validating the result for AbstractMt.xml() output + * Feat: Added an XSD for validating the Prowide Core proprietary XML version for MT messages generated by the `xml()` method for the `AbstractMT` and subclasses + * Feat: Added JSON schemas for the Prowide Core proprietary JSON version for MT messages generated by the `toJson()` method for the `SwiftMessage` and `MtSwiftMessage` classes + * Feat: Enhanced the `SwiftMessageComparator` to allow less strict comparison regarding Block 2's Sender Input Time and Receiver Output Time
39-46: Update SRU link to 2025 guide.Apply:
- * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) + * Yearly revision of the deprecation phase (see https://dev.prowidesoftware.com/SRU2025/getting-started/deprecation/)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: zubri
PR: prowide/prowide-core#190
File: build.gradle:43-43
Timestamp: 2024-11-19T16:30:09.444Z
Learning: In the Prowide Core project, significant changes such as major Java version upgrades (e.g., from Java 8 to Java 11) are properly documented in the `CHANGELOG.md` and migration notes.
📚 Learning: 2025-04-01T22:27:00.834Z
Learnt from: zubri
PR: prowide/pw-swift-enterprise#1352
File: CHANGELOG.md:3-5
Timestamp: 2025-04-01T22:27:00.834Z
Learning: The changelog formatting in this project should be maintained as is and not modified to follow standard Markdown linting rules. The current format uses h3 headings for version entries and indented bullet points.
Applied to files:
CHANGELOG.md
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
11-11: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
12-12: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
12-12: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
13-13: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
13-13: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
16-16: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
17-17: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
21-21: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
22-22: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
22-22: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
23-23: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
24-24: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
25-25: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
26-26: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
27-27: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
28-28: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
29-29: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
31-31: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
32-32: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
32-32: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
34-34: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
35-35: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
35-35: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
36-36: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
37-37: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
39-39: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
40-40: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
40-40: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
41-41: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
41-41: Bare URL used
(MD034, no-bare-urls)
42-42: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
43-43: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
44-44: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
45-45: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (java)
- GitHub Check: build
- GitHub Check: Analyze (java)
🔇 Additional comments (1)
CHANGELOG.md (1)
31-33: LGTM on 10.3.2 entry.
| #### 10.3.6 - August 2025 | ||
| * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks | ||
| * fix: `LogicalTerminalAddress` sender LT "X" is now the default instead of "A" for load balancing by Messaging Interface | ||
|
|
||
| #### 10.2.12 - July 2025 | ||
| #### 10.3.5 - September 2025 | ||
| * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks | ||
| * (PW-2613) Updated the Field70 codeword splitting logic to allow / as trailing chars |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Fix version/date ordering, dedupe entry, and correct exception name.
- 10.3.6 cannot predate 10.3.5; swap months to keep chronological order with versions.
- Record the SwiftParser fix once (keep in latest version).
- Use the correct Java exception: IndexOutOfBoundsException.
Apply:
-#### 10.3.6 - August 2025
+#### 10.3.6 - September 2025
- * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks
+ * feat: Enhanced SwiftParser to avoid IndexOutOfBoundsException when parsing messages with empty blocks
-#### 10.3.5 - September 2025
+#### 10.3.5 - August 2025
- * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks
- * (PW-2613) Updated the Field70 codeword splitting logic to allow / as trailing chars
+ * (PW-2613) Updated Field 70 codeword-splitting logic to allow '/' as trailing character(s)🏁 Script executed:
#!/bin/bash
set -e
# Locate CHANGELOG.md
file=$(find . -maxdepth 2 -type f -iname 'CHANGELOG.md' | head -n1)
echo "CHANGELOG file: $file"
echo
# List version entries with line numbers
grep -n '^#### ' "$file"
echo
# Check for incorrect exception name
grep -n 'OutOfBoundsException' "$file" || echo "No OutOfBoundsException found"
grep -n 'IndexOutOfBoundsException' "$file" || echo "No IndexOutOfBoundsException found"
echo
# Check for Field70 entry
grep -n 'Field70' "$file" || echo "No Field70 found"Length of output: 4113
Swap dates, dedupe SwiftParser fix, and correct exception name
- Swap the dates on 10.3.6 and 10.3.5 to keep chronological order (10.3.6 → September 2025; 10.3.5 → August 2025)
- Remove the duplicate SwiftParser entry from 10.3.5 so it only appears in 10.3.6
- Rename OutOfBoundsException to IndexOutOfBoundsException
- Tidy the Field70 entry: hyphenate “codeword-splitting,” quote “/,” and use “character(s)”
Apply:
-#### 10.3.6 - August 2025
+#### 10.3.6 - September 2025
- * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks
+ * feat: Enhanced SwiftParser to avoid IndexOutOfBoundsException when parsing messages with empty blocks
-#### 10.3.5 - September 2025
+#### 10.3.5 - August 2025
- * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks
- * (PW-2613) Updated the Field70 codeword splitting logic to allow / as trailing chars
+ * (PW-2613) Updated Field70 codeword-splitting logic to allow '/' as trailing character(s)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 10.3.6 - August 2025 | |
| * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks | |
| * fix: `LogicalTerminalAddress` sender LT "X" is now the default instead of "A" for load balancing by Messaging Interface | |
| #### 10.2.12 - July 2025 | |
| #### 10.3.5 - September 2025 | |
| * feat: Enhanced SwiftParser for edge cases avoiding OutOfBoundsException when parsing messages with empty blocks | |
| * (PW-2613) Updated the Field70 codeword splitting logic to allow / as trailing chars | |
| #### 10.3.6 - September 2025 | |
| * feat: Enhanced SwiftParser to avoid IndexOutOfBoundsException when parsing messages with empty blocks | |
| * fix: `LogicalTerminalAddress` sender LT "X" is now the default instead of "A" for load balancing by Messaging Interface | |
| #### 10.3.5 - August 2025 | |
| * (PW-2613) Updated Field70 codeword-splitting logic to allow '/' as trailing character(s) |
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 3 to 9, swap the release dates so 10.3.6 is
September 2025 and 10.3.5 is August 2025, remove the duplicate "Enhanced
SwiftParser..." line from 10.3.5 so it only appears under 10.3.6, rename
"OutOfBoundsException" to "IndexOutOfBoundsException", and tidy the Field70
entry to read something like "(PW-2613) Updated the Field70 codeword-splitting
logic to allow \"/\" as trailing character(s)"—hyphenate "codeword-splitting",
quote "/" and use "character(s)" for clarity.
Summary by CodeRabbit
New Features
Bug Fixes
Chores