Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name module cli tests, Add indexing to name genesis import, Fix e… #17

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Add name module cli tests, Add indexing to name genesis import, Fix e… #17

merged 1 commit into from
Jan 27, 2021

Conversation

channa-figure
Copy link
Contributor

…rror handling in name delete

@channa-figure channa-figure requested a review from a user January 27, 2021 15:01
iramiller
iramiller approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests is always a good PR!

@iramiller iramiller merged commit 309d3d4 into main Jan 27, 2021
@iramiller iramiller deleted the name-cli-tests branch January 27, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iramiller iramiller iramiller approved these changes

@mtps mtps Awaiting requested review from mtps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@channa-figure @iramiller