Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute cli tests #12

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Attribute cli tests #12

merged 6 commits into from
Jan 26, 2021

Conversation

channa-figure
Copy link
Contributor

The cli query and tx test for attribute tests are completed. I added the params command that was missing.

@channa-figure channa-figure requested a review from a user January 26, 2021 00:47
iramiller
iramiller previously approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good... we have to get the github action to pass to merge though.

@iramiller iramiller merged commit c691975 into main Jan 26, 2021
@iramiller iramiller deleted the attribute-cli-tests branch January 26, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iramiller iramiller iramiller approved these changes

@mtps mtps Awaiting requested review from mtps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@channa-figure @iramiller