Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update context init order to catch env flag #10

Merged
merged 3 commits into from
Jan 26, 2021
Merged

update context init order to catch env flag #10

merged 3 commits into from
Jan 26, 2021

Conversation

iramiller
Copy link
Member

Order of initialization would not capture envtype flag. Updated to set flag and use its value during preinit

@iramiller iramiller requested a review from a user January 25, 2021 21:03
@iramiller iramiller requested a review from mtps as a code owner January 25, 2021 21:03
channa-figure
channa-figure approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@channa-figure channa-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iramiller iramiller merged commit 22d66bf into main Jan 26, 2021
@iramiller iramiller deleted the bugfix/envtype-flag branch January 26, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@channa-figure channa-figure channa-figure approved these changes

@mtps mtps Awaiting requested review from mtps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iramiller @channa-figure