Make sure all decoders are released

Without catching decoder release exceptions, no more decoders are released after a release failed.
protyposis · Jan 2, 2017 · 0e67cbf · 0e67cbf
1 parent c0d74f9
commit 0e67cbf
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/MediaPlayer/src/main/java/net/protyposis/android/mediaplayer/Decoders.java b/MediaPlayer/src/main/java/net/protyposis/android/mediaplayer/Decoders.java
@@ -118,7 +118,13 @@ public MediaCodecDecoder.FrameInfo decodeFrame(boolean force) {
      */
     public void release() {
         for (MediaCodecDecoder decoder : mDecoders) {
-            decoder.release();
+            // Catch decoder.release() exceptions to avoid breaking the release loop on the first
+            // exception and leaking unreleased decoders.
+            try {
+                decoder.release();
+            } catch (Exception e) {
+                Log.e(TAG, "release failed", e);
+            }
         }
         mDecoders.clear();
     }