Image syncing #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for contribution! |
Author
|
Hmm, I didn't think you would immediately merge this into master :) I can imagine that people that sync lots of products don't want to add this extra overhead. |
Member
|
Hi!
Perhaps I was too quick. However - there's always version 2.0.1 sans new
feature.
Can you add that configuration setting (for image sync) in the Mageflow
admin section?
I guess it could be "off" by default. Big stores have very many images etc.
Br,
Sven
…On Thu, 27 Apr 2017 at 17:23, Ruud Seberechts ***@***.***> wrote:
Hmm, I didn't think you would immediately merge this into master :)
Shouldn't we take the side effects into consideration? I mean maybe there
should be an option somewhere when pulling products to sync images as well.
I can imagine that people that sync lots of products don't want to add
this extra overhead.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEfmOOhJsSig5C2YpU8cX6NGD8YVvQwpks5r0KTGgaJpZM4NF198>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds image syncing (meaning it will transfer the actual image data, and not only the database information.)
This is done by using the 'metainfo' field of a changeset, which contains the source URL, the image data is then received with a normal HTTP request on the moment of pulling.
Because the metainfo field is a VARCHAR with length 255, I noticed issues with too long JSON strings, so I added an update script to convert these to TEXT fields.
Possible side effects: Because of the image being copied at pull-time instead of push-time, the source image might have been removed or updated. Right now the image is only synced when the source is newer or the target image does not exist yet. This means rollbacks to previous images are not possible.