Add ability to use Closure as a sortable parameter in table's column #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR makes possible to use self-defined Closure as
sortable
parameter for table's column.There can be a case when you need to sort by computed or virtual column. You can't just set
sortable: true
in call tocolumn()
method. You can use Spatie Query Builder for such case. But this solution for those who don't want to install it just for one field.So, let's say you have such Eloquent model:
And you want to sort by
full_name
. Then you can do:P.S. I don't find instructions on how to set-up tests. So, right now there are no tests of this functionality.